Re: [Nbd] [PATCH v2] doc: Add new NBD_REP_INFO reply, for advertising block size

[Alex Bligh <alex@...872...>]

On 13 Apr 2016, at 08:27, Wouter Verhelst <w@...112...> wrote:

> Currently, there are no default minimum or maximum block sizes, and
> therefore they are effectively limited to "1 byte" for the minimum block
> size, and "the size of the device" for the maximum block size.
> 
> I do agree that it might be advantageous for the server to announce such
> minimum and maximum sizes, but I don't think that defining defaults that
> differ from what historically has been the effective default is the
> right way to go.
> 
> Therefore, I would like this to say that unless you announce
> differently, the maximum block size is the size of the device, and the
> minimum block size is 1 byte.
> 
> Having a default for preferred block size sounds sane, although it might
> be better to switch it to 4096 (which is what most conversations seem to
> use today) rather than 512.

+1

-- 
Alex Bligh