Re: [Nbd] [PATCH v2] doc: Add new NBD_REP_INFO reply, for advertising block size
- To: Alex Bligh <alex@...872...>, Wouter Verhelst <w@...112...>
- Cc: "nbd-general@lists.sourceforge.net" <nbd-general@lists.sourceforge.net>
- Subject: Re: [Nbd] [PATCH v2] doc: Add new NBD_REP_INFO reply, for advertising block size
- From: Eric Blake <eblake@...696...>
- Date: Wed, 13 Apr 2016 08:51:39 -0600
- Message-id: <570E5CFB.2040307@...696...>
- In-reply-to: <F35F7E5E-01F3-489A-BA3C-DDB36A34855C@...872...>
- References: <1460506614-31604-1-git-send-email-eblake@...696...> <20160413072754.GD19351@...3...> <A2FF8E68-397D-4C4D-8817-CC2A2A639046@...872...> <F35F7E5E-01F3-489A-BA3C-DDB36A34855C@...872...>
On 04/13/2016 05:41 AM, Alex Bligh wrote:
>
> On 13 Apr 2016, at 12:05, Alex Bligh <alex@...872...> wrote:
>
>>> Having a default for preferred block size sounds sane, although it might
>>> be better to switch it to 4096 (which is what most conversations seem to
>>> use today) rather than 512.
>>
>> +1
>
> Actually doubly +1, as this in theory allows for O_DIRECT type optimisation
> with 4k page sizes.
Telling clients to use a default preferred size of 64k (rather than 4k)
is still nice for O_DIRECT optimizations.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
Reply to: