[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH/RFC] Synchronize the option haggling phase



On 20 Apr 2016, at 16:48, Wouter Verhelst <w@...112...> wrote:

> On Tue, Apr 19, 2016 at 08:35:19AM +0100, Alex Bligh wrote:
>> 
>> On 18 Apr 2016, at 20:49, Eric Blake <eblake@...696...> wrote:
>> 
>>>> 
>>>> Signed-off-by: Alex Bligh <alex@...872...>
>>>> ---
>>>> doc/proto.md | 10 ++++------
>>>> 1 file changed, 4 insertions(+), 6 deletions(-)
>>>> 
>>>> This one is my preferred fix.
>>> 
>>> Also my preferred fix; my recent patch proposal for
>>> NBD_REP_ERR_BLOCK_SIZE_REQD is yet another case where strict lockstep
>>> between client requests and server responses makes life easier to reason
>>> about on whether a server will be using the error message in response to
>>> NBD_OPT_INFO, based on whether it has already seen NBD_OPT_BLOCK_SIZE.
>> 
>> Let's see if we can persuade Wouter :-)
> 
> After having given this some thought over the past two (very busy :-/)
> days, you have. Let's go with this.

Applied

-- 
Alex Bligh







Reply to: