Re: [Nbd] [PATCH/RFC] Synchronize the option haggling phase
- To: Wouter Verhelst <w@...112...>
- Cc: "nbd-general@lists.sourceforge.net" <nbd-general@lists.sourceforge.net>
- Subject: Re: [Nbd] [PATCH/RFC] Synchronize the option haggling phase
- From: Alex Bligh <alex@...872...>
- Date: Thu, 21 Apr 2016 11:29:55 +0100
- Message-id: <3B6F5D95-5AFB-49AC-837A-0549528CBD45@...872...>
- In-reply-to: <20160420154854.GB14164@...3...>
- References: <1460914313-24533-1-git-send-email-alex@...872...> <57153A59.80905@...696...> <1DEDFFAD-1857-41A0-89DF-15979439187E@...872...> <20160420154854.GB14164@...3...>
On 20 Apr 2016, at 16:48, Wouter Verhelst <w@...112...> wrote:
> On Tue, Apr 19, 2016 at 08:35:19AM +0100, Alex Bligh wrote:
>>
>> On 18 Apr 2016, at 20:49, Eric Blake <eblake@...696...> wrote:
>>
>>>>
>>>> Signed-off-by: Alex Bligh <alex@...872...>
>>>> ---
>>>> doc/proto.md | 10 ++++------
>>>> 1 file changed, 4 insertions(+), 6 deletions(-)
>>>>
>>>> This one is my preferred fix.
>>>
>>> Also my preferred fix; my recent patch proposal for
>>> NBD_REP_ERR_BLOCK_SIZE_REQD is yet another case where strict lockstep
>>> between client requests and server responses makes life easier to reason
>>> about on whether a server will be using the error message in response to
>>> NBD_OPT_INFO, based on whether it has already seen NBD_OPT_BLOCK_SIZE.
>>
>> Let's see if we can persuade Wouter :-)
>
> After having given this some thought over the past two (very busy :-/)
> days, you have. Let's go with this.
Applied
--
Alex Bligh
Reply to: