[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH/RFC] Synchronize the option haggling phase



On Mon, Apr 18, 2016 at 01:49:45PM -0600, Eric Blake wrote:
> plus simplifications to NBD_OPT_GO:
> 
> diff --git i/doc/proto.md w/doc/proto.md
> index 8ef339c..c85e0aa 100644
> --- i/doc/proto.md
> +++ w/doc/proto.md
> @@ -949,11 +949,7 @@ of the newstyle negotiation.
>      with `NBD_REP_ACK`), the client and the server both immediately
>      enter the transmission phase. The server MUST NOT send any zero
>      padding bytes after the `NBD_REP_ACK` data, whether or not the
> -    client negotiated the `NBD_FLAG_C_NO_ZEROES` flag. The server MUST
> -    NOT send the final `NBD_REP_ACK` reply until all other pending
> -    option replies have been sent by the server, and a client MUST NOT
> -    send any further option requests after `NBD_OPT_GO` unless it
> -    first receives an error reply.

These last two lines still apply; a client sending another option after
having sent NBD_OPT_GO is stupid.

-- 
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
       people in the world who think they really understand all of its rules,
       and pretty much all of them are just lying to themselves too.
 -- #debian-devel, OFTC, 2016-02-12



Reply to: