[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Columnar package list style (patch included)

Any chance to get this in?

On 2016-03-05 18:41, Christian Blichmann wrote:

On 2016-03-04 15:31, Julian Andres Klode wrote:

On Wed, Mar 02, 2016 at 11:56:09PM +0100, Christian Blichmann wrote:

[...]

A patch formatted with git format-patch is a great idea.



Done. My git-fu is weak.


Comments:
diff --git a/apt-private/private-cmndline.cc b/apt-private/private-cmndline.cc 
index 8290859..406f9ba 100644
--- a/apt-private/private-cmndline.cc
+++ b/apt-private/private-cmndline.cc
@@ -173,7 +173,8 @@ static bool addArgumentsAPTGet(std::vector<CommandLine::Args> &Args, char const 
       addArg(0, "show-progress", "DpkgPM::Progress", 0);
       addArg('f', "fix-broken", "APT::Get::Fix-Broken", 0);
       addArg(0, "purge", "APT::Get::Purge", 0);
-      addArg('V',"verbose-versions","APT::Get::Show-Versions",0);
+      addArg('V', "verbose-versions", "APT::Get::Show-Versions", 0);
+      addArg(0, "list-columns", "APT::Get::Show-Columns", 0);


list or show columns?



Done. It's now List-Columns.


[...]
diff --git a/apt-private/private-output.h b/apt-private/private-output.h 
index 8e4b50e..d99e2af 100644
--- a/apt-private/private-output.h
+++ b/apt-private/private-output.h
@@ -9,6 +9,7 @@
 #include <fstream>
 #include <string>
 #include <iostream>
+#include <vector>

 // forward declaration
 class pkgCacheFile;
@@ -34,6 +35,8 @@ void ListSingleVersion(pkgCacheFile &CacheFile, pkgRecords &records, APT_PUBLIC void ShowBroken(std::ostream &out, CacheFile &Cache, bool const Now); APT_PUBLIC void ShowBroken(std::ostream &out, pkgCacheFile &Cache, bool const Now);
+void ShowColumnarList(std::ostream &out, const std::vector<std::string> &List, size_t Indent, size_t ScreenWidth); 

Don't like columnar, but don't know why.



Done. Renamed to ShowWithColumns()


+
template<class Container, class PredicateC, class DisplayP, class DisplayV> bool ShowList(std::ostream &out, std::string const &Title, 
       Container const &cont,
       PredicateC Predicate,
@@ -43,7 +46,9 @@ template<class Container, class PredicateC, class DisplayP, class DisplayV> bool size_t const ScreenWidth = (::ScreenWidth > 3) ? ::ScreenWidth - 3 : 0; 
    int ScreenUsed = 0;
bool const ShowVersions = _config->FindB("APT::Get::Show-Versions", false); + bool const ShowColumnar = _config->FindB("APT::Get::Show-Columns", false); 

columnar or columns?



Done. It's ListColumns now.


[...]
No changelog entries, we autogenerate them from git commit messages.


Done.
Reply to: