On Sun, Jan 26, 2014 at 01:25:54PM +0100, Julian Andres Klode wrote: > They should be static. And I don't think it makes sense to change > the third argument from a size_t to a const char*. It's kind of > confusing as it's still a memchr. Ok, changed that. > I do not believe that this is any faster at all. On what architectures > did you test this? Especially important are amd64, armel, armhf. I only tested on amd64 (with libc6 version 2.13-38). However, I measured for a while now, the improvement doesn't seem to be very big: On average, the needed user time for "apt-get source sl" changed from 26.383s to 26.152s – that's ~0.9% difference. Not that much, so maybe this patch should be dropped? I didn't look at the precise numbers before submitting this patch, just had a quick look – I'll try to do that better in the future. :/ > You don't really need the cast here anymore. Ok, changed that.
Attachment:
signature.asc
Description: Digital signature