Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies
On Tue, Dec 31, 2013 at 11:40:34PM +0100, Michael Schaller wrote:
> On 12/31/2013 10:23 PM, Michael Vogt wrote:
> > Feel free to add yourself in the changelog, i.e. something like:
> > + [ Michael Schaller ]
>
> Done.
>
> On 12/31/2013 11:00 PM, Julian Andres Klode wrote:
> >It would be great if you could explain what the pyflakes issues were
> >in a separate paragraph of the commit message. Basically the second
> >sentence of the previous paragraph.
>
> Done.
>
> See the new patch attached.
> From 2d29cf5f820cd96b7776d08c05362a65acaa9e90 Mon Sep 17 00:00:00 2001
> From: Michael Schaller <michael@5challer.de>
> Date: Tue, 31 Dec 2013 23:22:32 +0100
> Subject: [PATCH]
It's still a git patch, so it should still have a summary line. git
tools are becoming a bit useless otherwise. I did not write “remove
the summary line”.
> * apt/cache.py:
> - Fixed PEP8 issues
> - Fixed pyflakes issue: Removed unused local variable 'transient'
> * apt/package.py:
> - Fixed PEP8 issues
> - Fixed pyflakes issue: Removed unused import 'warnings'
And git patches usually have prose text. I know that the latest commit
does not follow the usual git conventions, but I'm trying to get us
completely adopt them, because it just looks unnatural otherwise.
--
Julian Andres Klode - Debian Developer, Ubuntu Member
See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
Please do not top-post if possible.
Reply to: