Hi Julian, On 12/31/2013 01:29 AM, Julian Andres Klode wrote:
On Sun, Dec 29, 2013 at 12:06:18PM +0100, Michael Schaller wrote:Package: python-apt Version: 0.9.2 Severity: wishlist Tags: patchThis patch does far too many things that are not even remotely connected.
Fine by me. It's always hard for me to judge the right patch size if I contribute the first time to a project. I'm already happy that the overall idea of the patch seems to be acceptable. ;-)
>From 0d295006a98769cd6151c78b3a078ad92d8047ee Mon Sep 17 00:00:00 2001 From: Michael Wisheu <michael@5challer.de>Did you change your surname after writing the patch?
Good catch! I've got married two months ago and took my wife's last name. I'm still hunting down all the occurrences of my old last name and it looks like I've still had the old name in my git config. I wonder how I've managed to change my mail address but not my name... *sigh*
Anyhow... If you think this name change is fishy please let me know and I'll proof to you my identity and that the name change happened.
Before I start sending smaller patches could you please tell me if I should open new bugs or if we can handle all this in this one bug?Date: Sun, 29 Dec 2013 11:57:19 +0100 Subject: [PATCH] * apt/cache.py: - Fixed PEP8 linter and pyflakes issues - Added 'InstalledFilter' to get a filtered cache that only contains the currently installed packages. * apt/packages.py: - Fixed PEP8 linter issuesThe PEP8 stuff should be separate. The InstalledFilter should be separate- Removed special handling of 'collections' import as all supported distributions have Python 2.6 or newer by now.This should be separate- Replaced faulty 'BaseDependency.__dstr' with easier to read compat code.This should be separate- Added new properties to 'Dependency' and 'BaseDependency' to get the target package versions that could satisfy a dependency.Only this should be the patch.
Best, Michael