[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies



On Sun, Dec 29, 2013 at 12:06:18PM +0100, Michael Schaller wrote:
> Package: python-apt
> Version: 0.9.2
> Severity: wishlist
> Tags: patch

This patch does far too many things that are not even remotely
connected.

> >From 0d295006a98769cd6151c78b3a078ad92d8047ee Mon Sep 17 00:00:00 2001
> From: Michael Wisheu <michael@5challer.de>

Did you change your surname after writing the patch?

> Date: Sun, 29 Dec 2013 11:57:19 +0100
> Subject: [PATCH]
> * apt/cache.py:
>  - Fixed PEP8 linter and pyflakes issues
>  - Added 'InstalledFilter' to get a filtered cache that only contains the currently installed packages.
> * apt/packages.py:
>   - Fixed PEP8 linter issues

The PEP8 stuff should be separate.
The InstalledFilter should be separate

>   - Removed special handling of 'collections' import as all supported distributions have Python 2.6 or newer by now.

This should be separate

>   - Replaced faulty 'BaseDependency.__dstr' with easier to read compat code.

This should be separate

>   - Added new properties to 'Dependency' and 'BaseDependency' to get the target package versions that could satisfy a dependency.

Only this should be the patch.


-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Please do not top-post if possible.


Reply to: