Re: Bug#687492: unblock: aptitude/0.6.8.2-1 (pre-approve)
On Wed, Oct 31, 2012 at 8:51 AM, Daniel Hartwig <mandyke@gmail.com> wrote:
> On 31 October 2012 14:44, Adam D. Barratt <adam@adam-barratt.org.uk> wrote:
>> On Thu, 2012-09-13 at 17:45 +0800, Daniel Hartwig wrote:
>>> I have also attached another patch which is entirely optional, but of
>>> notable value to end users and relatively non-invasive. It brings in
>>> support for APT::Changelogs::Server which apt-cache and others have
>>> been using for some time. Previously we hardcoded the default value
>>> of that. Please also consider this patch and give it an ACK for
>>> inclusion if this is ok.
>>
>> + string server = aptcfg->Find("APT::Changelogs::Server",
>> + "http://packages.debian.org/changelogs";);
>>
>> I assume it's not possible to determine the default value being used by
>> apt here?
>
> Correct.
>
> Attached is patch for apt which would change that. CC to deity@
> for maybe comment.
I guess we can apply the patch to APT, but I still wouldn't change the
aptitude code here to avoid aptitude depending on a higher libapt-pkg
version (or alternatively breaking aptitude from libapt-pkg) just for this.
If we set it in apt-pkg/init.cc it will overrule whatever aptitude provides as
a default anyway (and I hope in general the URI isn't changing that often …).
The really interesting point Daniel has already said is that derivatives can
override this option with a configuration file which e.g. Ubuntu does already.
(They don't ship [complete?] changelog files anymore as far as I know,
so the command is a bit more useful for them than it is for us here)
Best regards
David Kalnischkies
P.S.: Daniel, I noticed that you haven't CC the unblock requests to the
aptitude-devel@ list, you might want to do that so it is easier to follow
what is happening in aptitude-land. ;)
Reply to: