Bug#649451: hard-coded gzip-only support in apt-cdrom
On Wed, Nov 23, 2011 at 04:09:23PM +0000, Steve McIntyre wrote:
> On Wed, Nov 23, 2011 at 05:01:13PM +0100, Michael Vogt wrote:
> >On Mon, Nov 21, 2011 at 06:57:41PM +0100, Julian Andres Klode wrote:
> >> On Mon, Nov 21, 2011 at 01:03:08PM +0100, David Kalnischkies wrote:
> >> > On Mon, Nov 21, 2011 at 01:26, Steve McIntyre <steve@einval.com> wrote:
> >> > > I've just added support for translated description files into
[..]
> >> It would be great if someone who actually needs it takes a look
> >> at it. That said, I have pushed out the following patch to
> >> the debian-experimental2 branch, please test it (I didn't
> >> test it, but it compiles and looks logically right).
> >[..]
> >
> >Thanks! This looks fine, I still changed it a bit to make use of the
> >APT::Configuration::getCompressionTypes() code so that we have only a
> >single place to add new compression types. Needs some serious testing
> >still.
>
> My own testing suggests it's necessary but not sufficient. The code in
> indexcopy.cc needs updating too to support things other than
> uncompressed and gzipped files. I've got a grotty patch that works for
> me but you *will* want to refactor. :-)
Oh, indeed, that code needs some serious love in general. But please
send us the patch :)
Cheers,
Michael
Reply to: