Bug#649451: hard-coded gzip-only support in apt-cdrom
On Mon, Nov 21, 2011 at 06:57:41PM +0100, Julian Andres Klode wrote:
> On Mon, Nov 21, 2011 at 01:03:08PM +0100, David Kalnischkies wrote:
> > On Mon, Nov 21, 2011 at 01:26, Steve McIntyre <steve@einval.com> wrote:
> > > I've just added support for translated description files into
> > > debian-cd, creating Translation-$LANG.bz2 on CDs to match the
> > > archive. A problem report from a user shortly afterwards described
> > > apt-cdrom issues using a DVD generated with this new code. [1] I've
> > > dug through the code in cdrom.cc and tagfile.cc and I've found that
> > > apt simply does not support .bz2 versions of the Translation files
> > > *from CD*. AFAICS it *does* support them in the main archive via HTTP
> > > etc. That's a bit of a surprise, to say the least.
> >
> > I am not that surprised, given that apt-cdrom is touched only once
> > in a blue moon - last serious change is from 2009 (udev), the one
> > before that is adding Translation support in 2007, the 2005 change
> > is imported from the previous vcs… You get the pattern.
> > All in all its properly save to say that the code you looked at mostly
> > comes straight from the last millennium (literally speaking!)…
> >
> > My personal excuse is that i haven't used it a single time, so i am
> > properly not the best one to hack on it, but i fear the rest of the
> > (lets count optimistic) trio seems to have the same excuse…
>
> Yes, definitely the same here. I don't even have a single Debian
> CD/DVD/Blu-Ray disc. I exclusively install systems via network,
> and do not use optical discs at all.
>
> It would be great if someone who actually needs it takes a look
> at it. That said, I have pushed out the following patch to
> the debian-experimental2 branch, please test it (I didn't
> test it, but it compiles and looks logically right).
[..]
Thanks! This looks fine, I still changed it a bit to make use of the
APT::Configuration::getCompressionTypes() code so that we have only a
single place to add new compression types. Needs some serious testing
still.
Cheers,
Michael
Reply to: