[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#316337: Here we are



The patch works just fine for me, after updating /var/lib/apt/lists/partial is still empty. If this patch makes it to the next version of APT, it would be useful to have the postinst script remove all the empty files in partial/, because remnants of earlier update runs can still cause trouble.

NB: I modified the patch a little, my patch(1) program was confused as to which file it should patch. The patch attached should be run through patch -p1.
diff -uprN a/methods/ftp.cc b/methods/ftp.cc
--- a/methods/ftp.cc	2006-05-08 15:21:16.748025568 +0200
+++ b/methods/ftp.cc	2006-05-08 15:21:00.000000000 +0200
@@ -1055,9 +1055,12 @@ bool FtpMethod::Fetch(FetchItem *Itm)
 	 UBuf.modtime = FailTime;
 	 utime(FailFile.c_str(),&UBuf);
 	 
-	 // If the file is missing we hard fail otherwise transient fail
-	 if (Missing == true)
+	 // If the file is missing we hard fail and delete the destfile
+	 // otherwise transient fail
+	 if (Missing == true) {
+	    unlink(FailFile.c_str());
 	    return false;
+	 }
 	 Fail(true);
 	 return true;
       }

Reply to: