Bug#316337: Here we are

[Michael Vogt <mvo@debian.org>]

On Sun, May 07, 2006 at 02:33:31PM +0200, roan.kattouw@home.nl wrote:
> >From traces/trace.2063 (helper/ftp)
> (FYI, 0 and 1 are a pipe to the main apt process, 3 is a socket to the Debian FTP server).
[..]

Thanks for your detailed analysis.
 
Could you please try the attached patch and tell me if it fixes the
problem? 

Thanks,
 Michael

-- 
Linux is not The Answer. Yes is the answer. Linux is The Question. - Neo

=== modified file 'methods/ftp.cc'
--- methods/ftp.cc	
+++ methods/ftp.cc	
@@ -1055,9 +1055,12 @@
 	 UBuf.modtime = FailTime;
 	 utime(FailFile.c_str(),&UBuf);
 	 
-	 // If the file is missing we hard fail otherwise transient fail
-	 if (Missing == true)
+	 // If the file is missing we hard fail and delete the destfile
+	 // otherwise transient fail
+	 if (Missing == true) {
+	    unlink(FailFile.c_str());
 	    return false;
+	 }
 	 Fail(true);
 	 return true;
       }