[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#909782: marked as done (libinput: please make the build reproducible)

Your message dated Fri, 11 Sep 2020 21:37:21 +0200
with message-id <87pn6shzpq.fsf@turtle.gmx.de>
and subject line Re: Bug#909782: libinput: please make the build reproducible
has caused the Debian Bug report #909782,
regarding libinput: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
909782: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=909782
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libinput
Version: 1.12.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that libinput could not be built reproducibly.

This is due to the LIBINPUT_QUIRKS_SRCDIR config.h variable including
the absolute build path to find the test-time input file.

Patch attached that uses a relative path instead. I'm not sure upstream
will like this patch, it is provided mostly as a demonstration
ofthe problem. However perhaps it could be modified to take an
environment variable instead? I will leave this with you.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

--- a/debian/patches/reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/reproducible-build.patch	2018-09-28 09:19:11.556126306 +0100
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2018-09-28
+
+--- libinput-1.12.0.orig/meson.build
++++ libinput-1.12.0/meson.build
+@@ -12,7 +12,7 @@ dir_libexec     = join_paths(get_option(
+ dir_lib         = join_paths(get_option('prefix'), get_option('libdir'))
+ dir_man1        = join_paths(get_option('prefix'), get_option('mandir'), 'man1')
+ dir_system_udev = join_paths(get_option('prefix'), 'lib', 'udev')
+-dir_src_quirks  = join_paths(meson.source_root(), 'quirks')
++dir_src_quirks  = '../quirks'
+ dir_src_test    = join_paths(meson.source_root(), 'test')
+ dir_src         = join_paths(meson.source_root(), 'src')
+ 
--- a/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/series	2018-09-28 09:18:30.095886370 +0100
@@ -0,0 +1 @@
+reproducible-build.patch

--- End Message ---
--- Begin Message --- 
Package: libinput
Version: 1.16.1-1

On 2020-09-09 11:55 +0200, Julien Cristau wrote:

> Control: tag -1 - patch
> Control: tag -1 + upstream
>
> On Mon, Aug 31, 2020 at 07:03:38AM -0400, Chris Lamb wrote:
>> Dear Maintainer,
>>
>> > Source: libinput
>> > Version: 1.12.6-2+deb10u1
>> > Tags: patch
>>
>> There hasn't seem to be any update on this bug in 703 days, in which
>> time the Reproducible Builds effort has come on a long way.
>>
>> Would you consider applying this patch and uploading?
>>
> The patch doesn't seem quite right, so I don't think we should apply it
> as-is.  It seems to me LIBINPUT_QUIRKS_SRCDIR shouldn't be in the
> shipped packages at all, so a patch that fixes that and can be sent
> upstream would be better.

Apparently this is no longer necessary, for I could not find any
references to that directory in the binary packages.  Building libinput
in two different directories produced identical packages here and on
[1], so I have taken the liberty to close the bug. :-)

Cheers,
       Sven


1. https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libinput.html

--- End Message ---
Reply to: