Bug#892956: libinput-dev: Requires.private without package dependencies breaks pkg-config users
Control: reassign -1 meson 0.45.0-1
Control: retitle -1 meson creates bogus pkgconfig files
Control: affects -1 libinput-dev
On Thu, Mar 15, 2018 at 06:38:30PM +0100, Andreas Metzler wrote:
> On 2018-03-15 Timo Aaltonen <tjaalton@debian.org> wrote:
> > On 14.03.2018 22:25, Adrian Bunk wrote:
> > > Package: libinput-dev
> [...]
> > > Root cause are the new dependencies in Requires.private
> > > without package dependencies:
>
> > > $ pkg-config --cflags libinput
> > > Package libwacom was not found in the pkg-config search path.
> > > Perhaps you should add the directory containing `libwacom.pc'
> > > to the PKG_CONFIG_PATH environment variable
> > > Package 'libwacom', required by 'libinput', not found
>
> > 1.10.2-1 didn't have them, and nothing changed in 1.10.3 that would
> > result in this, so the culprit is elsewhere. Where did that
> > "Requires.private" come from?
>
> Hello,
>
> Meson changed:
Thanks.
> --- ./libinput-1.10.3-builtwithmeson0.44.1-1/debian/libinput-dev/usr/lib/x86_64-linux-gnu/pkgconfig/libinput.pc 2018-03-15 18:24:08.366925927 +0100
> +++ ./libinput-1.10.3-builtwithmeson0.45.0-1/debian/libinput-dev/usr/lib/x86_64-linux-gnu/pkgconfig/libinput.pc 2018-03-15 18:15:49.059380110 +0100
> @@ -5,5 +5,7 @@ includedir=${prefix}/include
> Name: Libinput
> Description: Input device library
> Version: 1.10.3
> +Requires.private: libwacom libudev mtdev libevdev
This is wrong.
Whether or not libinput internally uses other libraries like libwacom is
an implementation detail, not something that should leak through the cflags.
It bloats the command line with tons of unnecessary -I flags.
And in some cases it also leaks whatever other flags are in the cflags
of the libraries used by libinput.
> Libs: -L${libdir} -linput
> +Libs.private: -lm -lrt -L${libdir} -llibinput-util
-llibinput-util would be liblibinput-util.a, that's clearly bogus.
> Cflags: -I${includedir}
>
> I guess the source was merging of
> https://github.com/mesonbuild/meson/pull/3131
>
> cu Andreas
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
Reply to: