[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#789939: xserver-xorg-core: vesa int10 doesn't work, patch available



Package: xserver-xorg-core
Version: 2:1.17.1-2
Severity: important
Tags: upstream patch

Dear Maintainer,

Currently this package doesn't when using the VESA driver; the error is visible in Xorg.0.log.

This is especially important for hurd (where I experienced this bug) because that's the only driver available in practice.

It is fixed in ubuntu; 

xorg-server (2:1.17.1-0ubuntu3) vivid; urgency=medium

  * Add a patch to fix vesa int10 failure. (LP: #1433198)

 -- Maarten Lankhorst <maarten.lankhorst@ubuntu.com>  Thu, 19 Mar 2015 10:13:08 +0100

I am attaching the patch for that to this bug report.
From: Jürg Billeter <j@bitron.ch>
To: xorg-devel@lists.x.org
Subject: [PATCH xserver] int10: Fix error check for pci_device_map_legacy
Date: Sat,  7 Feb 2015 18:13:21 +0100
Message-Id: <1423329201-32163-1-git-send-email-j@bitron.ch>
List-Id: "X.Org development list" <xorg-devel.lists.x.org>

pci_device_map_legacy returns 0 on success.

Signed-off-by: Jürg Billeter <j@bitron.ch>
---
 hw/xfree86/int10/generic.c                | 2 +-
 hw/xfree86/os-support/linux/int10/linux.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/xfree86/int10/generic.c b/hw/xfree86/int10/generic.c
index 012d194..8d5c4da 100644
--- a/hw/xfree86/int10/generic.c
+++ b/hw/xfree86/int10/generic.c
@@ -104,7 +104,7 @@ readIntVec(struct pci_device *dev, unsigned char *buf, int len)
 {
     void *map;
 
-    if (!pci_device_map_legacy(dev, 0, len, 0, &map))
+    if (pci_device_map_legacy(dev, 0, len, 0, &map))
         return FALSE;
 
     memcpy(buf, map, len);
diff --git a/hw/xfree86/os-support/linux/int10/linux.c b/hw/xfree86/os-support/linux/int10/linux.c
index 79b9a88..6ca118f 100644
--- a/hw/xfree86/os-support/linux/int10/linux.c
+++ b/hw/xfree86/os-support/linux/int10/linux.c
@@ -75,7 +75,7 @@ readLegacy(struct pci_device *dev, unsigned char *buf, int base, int len)
 {
     void *map;
 
-    if (!pci_device_map_legacy(dev, base, len, 0, &map))
+    if (pci_device_map_legacy(dev, base, len, 0, &map))
         return FALSE;
 
     memcpy(buf, map, len);
-- 2.3.0

Reply to: