Re: xorg intel package bug?
On Tue, Aug 19, 2014 at 03:13:04PM +0200, BubuXP wrote:
> 2014-08-19 12:18 GMT+02:00 Vincent Cheng <vcheng@debian.org>:
> >
> > Hi,
> >
> > (Cc-ing debian-x@l.d.o)
> >
> > On Mon, Aug 18, 2014 at 5:08 AM, BubuXP <bubuxp@gmail.com> wrote:
> > > While compiling upstream snapshots for debian
> > > https://drive.google.com/folderview?id=0B7AdLMiZn4FzdGZNV2FpLWhPTkk
> > > I found that valgrind is disabled.
> > > Is this the expected behavior?
> > > I'm not a programmer, just a power user, but reading in the debian/rules
> > > file it has the following code:
> > >
> > >
> > > DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH)
> > >
> > > ifeq ($(DEB_HOST_ARCH), linux)
> > > valgrind = --enable-valgrind
> > > else
> > > valgrind = --disable-valgrind
> > > endif
> > >
> > >
> > > DEB_HOST_ARCH will report 'amd64' or 'i386' as values, but it will never be
> > > equal to 'linux' so valgrind will be always disabled. I suspect that instead
> > > of DEB_HOST_ARCH you should use the DEB_HOST_ARCH_OS variable, that reports
> > > 'linux' as value.
> >
> > Nice catch, thanks!
> >
> > (I guess that leads to another question, i.e. should we be building
> > xserver-xorg-video-intel with --enable-valgrind by default? It looks
> > like the change was added in 2:2.21.14-1, although due to the above
> > typo xxv-intel in both sid and experimental have always been built
> > with --disable-valgrind, and that's also the upstream default.)
>
> In version 2:2.21.14-1 valgrind was enabled by default, but after a
> couple of hours version 2:2.21.14-2 was released with "Don't enable
> valgrind on kfreebsd" in changelog.
> So I think the above lines in debian/rules must change in:
>
I am doubtfull about your "must".
I do have a severe dislike of valgrind, it is super *slow*.
Very happy about the new sanitize gcc targets.
--
maks
Reply to: