Re: xorg intel package bug?
Hi,
(Cc-ing debian-x@l.d.o)
On Mon, Aug 18, 2014 at 5:08 AM, BubuXP <bubuxp@gmail.com> wrote:
> While compiling upstream snapshots for debian
> https://drive.google.com/folderview?id=0B7AdLMiZn4FzdGZNV2FpLWhPTkk
> I found that valgrind is disabled.
> Is this the expected behavior?
> I'm not a programmer, just a power user, but reading in the debian/rules
> file it has the following code:
>
>
> DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH)
>
> ifeq ($(DEB_HOST_ARCH), linux)
> valgrind = --enable-valgrind
> else
> valgrind = --disable-valgrind
> endif
>
>
> DEB_HOST_ARCH will report 'amd64' or 'i386' as values, but it will never be
> equal to 'linux' so valgrind will be always disabled. I suspect that instead
> of DEB_HOST_ARCH you should use the DEB_HOST_ARCH_OS variable, that reports
> 'linux' as value.
Nice catch, thanks!
(I guess that leads to another question, i.e. should we be building
xserver-xorg-video-intel with --enable-valgrind by default? It looks
like the change was added in 2:2.21.14-1, although due to the above
typo xxv-intel in both sid and experimental have always been built
with --disable-valgrind, and that's also the upstream default.)
> BTW, do you think it's ok to upload an updated xserver-xorg-video-intel
> package to the wheezy-backports repository? I compiled it successfully in
> wheezy, it only required updated drm packages to compile but the resulting
> packages were ok with the version in wheezy.
Perhaps someone on the list may be interested in doing so? If not, you
can always ask around on debian-backports@l.d.o. I don't really have
the time to maintain a backport of xxv-intel, and that's just one
small piece out of all the userspace components that are candidates
for being backported (I presume that you want these backports for
improved hardware support?).
It's also worth noting that your link above suggests that you've
backported the current xxv-intel package in experimental, whereas only
packages in testing are eligible to be backported via
debian-backports.
Regards,
Vincent
Reply to: