[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#612681: x11-common: treat empty session names silently as default session



On 05/16/2011 03:51 PM, Agustin Martin wrote:
On Mon, May 16, 2011 at 01:37:01PM +0200, Agustin Martin wrote:
On Wed, Feb 09, 2011 at 11:30:47PM +0100, Malte S. Stretz wrote:
Package: x11-common
Version: 1:7.5+6ubuntu3
Severity: wishlist
Tags: patch

When I upgraded to KDE 4.6.0 recently, some weird bug in kdm (I guess, haven't
had the time to research further) started Xsession with an empty first
argument.  This resulted in the message 'Xsession: unable to launch "" X
session --- "" not found; falling back to default session.' My suggestion is to
interpret an empty first argument (which will of course never work as a session
manager) the same as no arguments and just silently fall back to the default
session. The rationale is that the user who is confronted with such a behaviour
can't really do anything about it.

The original bug was reported on launchpad at
<https://launchpad.net/bugs/710144>  but I forwarded it here since this is an
unmodified file from Debian.
For the records, I am having the same problem with slim and wdm, only in sid
(at least, until today's testing upgrade, which I still did not test)

For both, selecting an explicitly available session temporarily helps, but
I'd prefer something like in your proposed patches.
Trying with my just upgraded testing and my problem started to appear.

I added some lines to get debugging info displayed, and now I think
mine is not the same problem as yours. While I indeed saw the message you
mention when using slim (and thus, I think something like your patch should
be included), seems that my real problem is that icewm-session is behaving
badly.

In this box, after looking at the extra info, when using default, seems that
correct selection is done (icewm-session in my case).

However, is that specific selection which fails, even if I explicitly select
it. Selecting plain icewm does work.

These are the .xsession-error messages for the failing icewm-session invocation
from wdm (lines with AMD-WARNING are the extra info I requested)

Xsession: X session started for testuser at Mon May 16 15:26:28 CEST 2011
Xsession: AMD-WARNING: Running "/etc/X11/wdm/Xsession" with arguments "icewm-session"
Xsession: AMD-WARNING: Passing session as argument "icewm-session"
/home/testuser/.Xresources:1:24: warning: missing terminating ' character
/home/testuser/.Xresources:13:28: warning: missing terminating ' character
Xsession: AMD-WARNING: starting "/usr/bin/ssh-agent
/usr/bin/ck-launch-session /usr/bin/dbus-launch --exit-with-session
icewm-session"
icewm-session: using /home/testuser/.icewm for private configuration files
IceWM: using /home/testuser/.icewm for private configuration files
icewmtray: using /home/testuser/.icewm for private configuration files
icewmbg: using /home/testuser/.icewm for private configuration files
XIO:  fatal IO error 104 (Connection reset by peer) on X server ":0"
       after 205 requests (205 known processed) with 2 events remaining.
XIO:  fatal IO error 11 (Resource temporarily unavailable) on X server ":0"
       after 110 requests (105 known processed) with 0 events remaining.
XIO:  fatal IO error 104 (Connection reset by peer) on X server ":0"
       after 122 requests (122 known processed) with 0 events remaining.
Invalid MIT-MAGIC-COOKIE-1 keyicewmbg: Can't open display: :0. X must be
running and $DISPLAY set.
Does the X server crash here? Any messages in Xorg log? I found a bug in X in Fedora that fails like this, might be the same.

Mark
and these are for the sucessful icewm start from wdm.

Xsession: X session started for testuser at Mon May 16 15:26:45 CEST 2011
Xsession: AMD-WARNING: Running "/etc/X11/wdm/Xsession" with arguments "icewm"
Xsession: AMD-WARNING: Passing session as argument "icewm"
/home/testuser/.Xresources:1:24: warning: missing terminating ' character
/home/testuser/.Xresources:13:28: warning: missing terminating ' character
Xsession: AMD-WARNING: starting "/usr/bin/ssh-agent
/usr/bin/ck-launch-session /usr/bin/dbus-launch --exit-with-session icewm"
IceWM: using /home/testuser/.icewm for private configuration files
IceWM: MappingNotify

Will look a bit more at this in case I can get some info and file a bug
report with it against icewm. This seems completely unrelated to your
original bug report.

Regards,





Reply to: