Re: xorg-server fix for Gamma crashes when screensaver starts

[Uwe Kleine-König <u.kleine-koenig@pengutronix.de>]

Hello,

[added Keith Packard and "my" Debian bug to the addressees]

On Fri, Feb 26, 2010 at 12:16:18AM +0100, Brice Goglin wrote:
> Hello,
> 
> You've had problems with Xserver 1.7.4 crashing in some Gamma functions
> when the screensaver starts (bugs #554450, #565773 and #567318). It was
> supposed to be fixed in xserver-xorg-core 1.7.5, but only part of the
> problem was actually fixed and most of your issues probably still occur
> with 1.7.5. If you indeed have an easy way to reproduce the crash with
> 1.7.5, could you please test the candidate patch from Keith Packard ?
>  
> http://cgit.freedesktop.org/xorg/xserver/commit/?h=compat_output&id=cba2af9aff2e95e937d504e18171406a6e3dcccb
> Just apply it to the xorg-server source package and rebuild.
I havn't tested it yet (but I already started rebuilding the package),
but just reading the changelog makes me wonder if this really fixes the
problem.

The Symptoms for me are that if gnome-screensaver locks the screen
X reproducibly segfaults.  But if I changed once to another console and
back (i.e. press Ctrl+Alt+F1, Alt+F7) the problems are gone and
gnome-screensaver can lock the screen just fine.

So checking for crtc being NULL is right, but AFAICT it shouldn't be
NULL before the console switch in the first place.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |