Julien Cristau wrote:
On Thu, Sep 3, 2009 at 01:50:05 +0000, David Nusinow wrote:diff --git a/debian/compat b/debian/compat index 7ed6ff8..7f8f011 100644 --- a/debian/compat +++ b/debian/compat @@ -1 +1 @@ -5 +7 diff --git a/debian/rules b/debian/rules index d237d45..7a61b23 100755 --- a/debian/rules +++ b/debian/rules @@ -18,6 +18,7 @@ endif xkb_base := /usr/share/X11/xkbconfigure: $(STAMP_DIR)/patch+ dh_prep intltoolize -c -f autoreconf -vfiI don't think dh_prep belongs here. AFAIK it belongs in the install target.
Pasted from the dh_prep manpage:
DESCRIPTION
dh_prep is a debhelper program that performs some file cleanups in
preparation for building a package. (This is what dh_clean -k used to
do.) It removes the package build directories, debian/tmp, and some
temp files that are generated during the build. Putting this at the
start of the build process makes the build process idempotent.
So the documentation talks about it as being for cleanups prior to
building the package. Is there a reason this should go in the install
target? It's entirely possible that there's some interaction between the
Makefile targets that I'm missing that makes it optimal to add to the
install target as well.
Also, is there any particular reason for bumping the debhelper compat level? I've been holding off on moving to something > 5 unless I was using the new dh stuff, so far.
There's no major need, but I'd rather stay on top of it so we don't have to worry about updating it later when v5 becomes deprecated. Since no one seems to be particularly interested in backporting these X packages to the current stable it shouldn't cause any real problems. It's not a big deal though and if you'd rather stay at v5 and above (v4 is currently deprecated) I'm fine with that.
- David Nusinow