Bug#524280: Display broken beyond recognition after upgrade to 1:6.12.2-1
On Wed, May 13, 2009 at 10:34:39AM +0200, Michel Dänzer wrote:
>The point is that if you say git bisect good/bad for a commit where you
>couldn't verify the problem you're bisecting, the result of the bisect
>run may be incorrect.
I know that. But even when such assumption leads to incorrect results,
I can always do a replay changing guessed good/bad answer. This will
lead ultimately to "close enough" result, just like it did in my
example.
>Also note that if you know the fix for a build problem and you're
>confident it doesn't affect the problem you're bisecting, it's
>legitimate to manually apply the build fix.
I also know that.
However I'm just a regular user. Don't expect me to be able to fix
compilation error of xorg video driver... Especially to fix it in a
way that I'm confident won't break anything else.
I started git bisect between revisions
a6561f2ec673b38907f7181235386f32e60c32ba and
da021c36bbdf3bca31ee50ebe01cdb9495c09b36, but I really don't think
it's getting anywhere. I've attached an exemplary log of 'make'
invocation (the same error for every tested build).
Being able to fix this build problem, I'd be able to do further git
bisect on driver repository.
--
Jacek Politowski
Script started on śro, 13 maj 2009, 12:49:12
jpol@unstable-builder:~/workspace/radeon/upstream/gitrepo/xf86-video-ati$ make
make all-recursive
make[1]: Wejście do katalogu `/home/jpol/workspace/radeon/upstream/gitrepo/xf86-video-ati'
Making all in src
make[2]: Wejście do katalogu `/home/jpol/workspace/radeon/upstream/gitrepo/xf86-video-ati/src'
/bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I./AtomBios/includes -Wall -I/usr/include/xorg -I/usr/include/pixman-1 -I/usr/include/drm -I/usr/include/X11/dri -DDISABLE_EASF -DENABLE_ALL_SERVICE_FUNCTIONS -DATOM_BIOS -DATOM_BIOS_PARSER -DDRIVER_PARSER -g -O2 -MT radeon_accel.lo -MD -MP -MF .deps/radeon_accel.Tpo -c -o radeon_accel.lo radeon_accel.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I./AtomBios/includes -Wall -I/usr/include/xorg -I/usr/include/pixman-1 -I/usr/include/drm -I/usr/include/X11/dri -DDISABLE_EASF -DENABLE_ALL_SERVICE_FUNCTIONS -DATOM_BIOS -DATOM_BIOS_PARSER -DDRIVER_PARSER -g -O2 -MT radeon_accel.lo -MD -MP -MF .deps/radeon_accel.Tpo -c radeon_accel.c -fPIC -DPIC -o .libs/radeon_accel.o
In file included from radeon_accel.c:86:
radeon_drm.h:584: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘__attribute__’ before ‘*’ token
radeon_drm.h:610: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘__attribute__’ before ‘*’ token
radeon_drm.h:627: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘__attribute__’ before ‘*’ token
radeon_drm.h:635: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘__attribute__’ before ‘*’ token
radeon_drm.h:644: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘__attribute__’ before ‘*’ token
radeon_drm.h:648: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘__attribute__’ before ‘*’ token
radeon_drm.h:689: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘__attribute__’ before ‘*’ token
radeon_drm.h:701: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘__attribute__’ before ‘*’ token
radeon_drm.h:718: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘__attribute__’ before ‘*’ token
radeon_accel.c: In function ‘RADEONEngineInit’:
radeon_accel.c:379: error: ‘drm_radeon_getparam_t’ has no member named ‘value’
make[2]: *** [radeon_accel.lo] Błąd 1
make[2]: Opuszczenie katalogu `/home/jpol/workspace/radeon/upstream/gitrepo/xf86-video-ati/src'
make[1]: *** [all-recursive] Błąd 1
make[1]: Opuszczenie katalogu `/home/jpol/workspace/radeon/upstream/gitrepo/xf86-video-ati'
make: *** [all] Błąd 2
jpol@unstable-builder:~/workspace/radeon/upstream/gitrepo/xf86-video-ati$ exit
Script done on śro, 13 maj 2009, 12:49:16
# bad: [da021c36bbdf3bca31ee50ebe01cdb9495c09b36] radeon_drm.h: remove kernel defines
# good: [a6561f2ec673b38907f7181235386f32e60c32ba] Move DRI to a separate struct
git bisect start 'da021c36bbdf3bca31ee50ebe01cdb9495c09b36' 'a6561f2ec673b38907f7181235386f32e60c32ba'
# skip: [4a9e8d9fe24278b56aef51677fd35289d01584a7] set grey levels correctly for temporal dithering
git bisect skip 4a9e8d9fe24278b56aef51677fd35289d01584a7
# skip: [dc795ba66a8c0eb2c3fdb86bd42dfc17e0aa3b6e] Fixups from last DFP/LCD refactor
git bisect skip dc795ba66a8c0eb2c3fdb86bd42dfc17e0aa3b6e
# skip: [5708624d1151877dd66a462d4a75fed6774604a7] Turn coherent mode off by default on DVI
git bisect skip 5708624d1151877dd66a462d4a75fed6774604a7
# skip: [d744dc013cf5ca3141c0fdf55e36d713fe9f53ba] Fix connector table mapping for lvtma/kaleidoscope/uniphy.
git bisect skip d744dc013cf5ca3141c0fdf55e36d713fe9f53ba
Reply to: