Re: fix 05_module_defaults.diff in xorg-server 1.3 when there is no Module section
On Fri, Apr 20, 2007 at 07:49:33PM +0200, Brice Goglin wrote:
> Hi David,
>
> After upgrading to xserver-xorg-core 1.3, some applications started to
> complain that the GLX extension was missing. The cause was that the
> "glx" module was not loaded while it was with -rc5. The problem is that
> I don't have any Module section anymore at all (I almost removed
> everything from my xorg.conf).
>
> With your patch 05_module_defaults.diff, when you have an *empty* module
> section, default modules are loaded fine. However, if there is no such
> section at all (as in my xorg.conf), no default module is loaded.
>
> Maybe you'll find an easier way to fix this, but at least the attached
> patch seems to work fine here. What it does is:
> * add all default/TRUE modules to the list of load directives when there
> is no Module section
> * move the counting of modules to load after the if(there is a module
> section)then{}else{} so that we also count in the above case too
It looks good to me. Thanks for handling this! I'm glad I pushed the patch
to Debian before putting it upstream for just this reason. Feel free to add
your patch and we'll get it uploaded for testing.
- David Nusinow
Reply to: