[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#392546: marked as done (xserver-xorg-video-sis: Missing symbol causes X to barf)

Your message dated Fri, 13 Oct 2006 14:49:44 -0700
with message-id <E1GYUuW-0008DO-9t@spohr.debian.org>
and subject line Bug#392546: fixed in xserver-xorg-video-sis 1:0.9.1-4
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: xserver-xorg-video-sis
Version: 1:0.9.1-3
Severity: grave
Tags: patch
Justification: renders package unusable


Hi,

After upgrading to this version of xserver-xorg-video-sis, when I next 
restarted X, it got partway through loading, switched the video mode, 
and then died, leaving the console unusable.  I found the following 
message in the logs:

xdm.log.1:/usr/bin/X: symbol lookup error: /usr/lib/xorg/modules/drivers/sis_drv.so: undefined symbol: assert

It turns out that this version (or another recent one) added a call to 
assert(3) in the code.  But it did not include <assert.h>.  It still 
compiles, with an "implicit declaration" warning, but a reference to the 
symbol "assert" is left in the object.  Since assert(3) is a macro and 
not a function, "assert" cannot be resolved by the dynamic linker.  Thus 
X fails to load the module and pukes all over the console.

The fix is to add "#include <assert.h>" in src/sis.h. 

There are a few other "implicit declaration" warnings generated 
elsewhere in the code.  They aren't causing problems at present because 
the functions in question are actually functions, and their default 
declarations seem to be adequate.  But they might as well be fixed to 
avoid future problems.  So also add to src/sis.h:

#include <unistd.h>
#include <stdlib.h>
#include <fcntl.h>
#include <sys/ioctl.h>


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17debian9
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages xserver-xorg-video-sis depends on:
ii  libc6                        2.3.6.ds1-6 GNU C Library: Shared libraries
ii  xserver-xorg-core            2:1.1.1-9   X.Org X server -- core server

xserver-xorg-video-sis recommends no packages.

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: xserver-xorg-video-sis
Source-Version: 1:0.9.1-4

We believe that the bug you reported is fixed in the latest version of
xserver-xorg-video-sis, which is due to be installed in the Debian FTP archive:

xserver-xorg-video-sis_0.9.1-4.diff.gz
  to pool/main/x/xserver-xorg-video-sis/xserver-xorg-video-sis_0.9.1-4.diff.gz
xserver-xorg-video-sis_0.9.1-4.dsc
  to pool/main/x/xserver-xorg-video-sis/xserver-xorg-video-sis_0.9.1-4.dsc
xserver-xorg-video-sis_0.9.1-4_i386.deb
  to pool/main/x/xserver-xorg-video-sis/xserver-xorg-video-sis_0.9.1-4_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 392546@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David Nusinow <dnusinow@debian.org> (supplier of updated xserver-xorg-video-sis package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 13 Oct 2006 16:50:58 -0400
Source: xserver-xorg-video-sis
Binary: xserver-xorg-video-sis
Architecture: source i386
Version: 1:0.9.1-4
Distribution: unstable
Urgency: low
Maintainer: David Nusinow <dnusinow@debian.org>
Changed-By: David Nusinow <dnusinow@debian.org>
Description: 
 xserver-xorg-video-sis - X.Org X server -- SiS display driver
Closes: 392546 392595
Changes: 
 xserver-xorg-video-sis (1:0.9.1-4) unstable; urgency=low
 .
   * Add 01_missing_assert.diff to include assert.h because the driver now uses
     the assert macro. Thanks Nate Eldredge. Closes: #392546
   * Add 02_missing_unistd.diff to include unistd.h and fcntl.h because
     sis_regs.h and sis_driver.c uses various functions defined in there, and
     yet it doesn't include it. Thanks Martin Michlmayr. Closes: #392595
Files: 
 e43def26f1969e8564e53da462758686 1095 x11 optional xserver-xorg-video-sis_0.9.1-4.dsc
 a2aa77340b55e992fcc5b9f94487029a 93074 x11 optional xserver-xorg-video-sis_0.9.1-4.diff.gz
 13ff41704d2376bb4613cf45ef00ddbe 278852 x11 optional xserver-xorg-video-sis_0.9.1-4_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFL/3AyLfpNdY0ad8RAq5EAJ9FXN+vapsef7Mcigfjm4eGIkfqiACeM8su
CZ7EfISOuVMAOr+WzSAa8ns=
=Bcud
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: