[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#363362: x11-common: postinst fails if /usr/X11R6/bin is not empty



On Tue, Apr 18, 2006 at 08:26:37PM +0200, Josselin Mouette wrote:
> Le mardi 18 avril 2006 à 11:14 -0700, Steve Langasek a écrit :
> > > The postinst contains the following:
> > > if [ -d "/usr/X11R6/bin" ] && [ ! -L /usr/X11R6/bin ]; then
> > >   rmdir "/usr/X11R6/bin" || die "Could not remove /usr/X11R6/bin. Is not 
> > > yet empty. Please remove any items still in the directory. You can move 
> > > them back after the install has completed successfully."
> > > fi

> > This is a duplicate of bug #362885.  Unless you can come up with a better
> > upgrade path than the one that's been implemented, it's also a non-bug.

> For sure I have a better upgrade path: 
> - keep a compatibility symbolic link in /usr/X11R6/bin/X, and ditto the
> few other ones that can cause breakage upon upgrade ;
> - hunt down packages using them ;
> - release etch with those links ;
> - entirely remove /usr/X11R6/bin after the release.

> There are many broken third-party applications that install stuff
> in /usr/X11R6 instead of /usr/local. Until now, such cases have been
> handled by overwriting them upon upgrades, not by entirely failing to
> upgrade. The "upgrade path" (which is actually a non-upgrade path) will
> break on many systems without any justification.

Issues this doesn't address:

- /usr/X11R6/bin is not in the path in Debian's /etc/profile, so any partial
  upgrades or not-yet-transitioned packages will leave some users (and their
  scripts) unable to find some of their programs
- just as broken third-party applications may install stuff in /usr/X11R6
  instead of /usr/local, broken third-party applications may hard-code paths
  to programs they call instead of using the system path

So you're trading one sort of brokenness for another.

I have a strong preference for keeping such brokenness self-contained;
failing to upgrade when the directory is non-empty is one way to achieve
this.

Ultimately, it's the XSF's decision which way they want to do it, though,
not mine.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon@debian.org                                   http://www.debian.org/

Attachment: signature.asc
Description: Digital signature


Reply to: