Bug#363362: x11-common: postinst fails if /usr/X11R6/bin is not empty

[Josselin Mouette <joss@debian.org>]

Package: x11-common
Version: 1:7.0.14
Severity: grave

The postinst contains the following:
if [ -d "/usr/X11R6/bin" ] && [ ! -L /usr/X11R6/bin ]; then
  rmdir "/usr/X11R6/bin" || die "Could not remove /usr/X11R6/bin. Is not 
yet empty. Please remove any items still in the directory. You can move 
them back after the install has completed successfully."
fi

When I met this error I first checked whether it was April 1st or 
something. I don't think this is acceptable to stomp on such a minor 
error, especially when previous upgrades happen to let some files in 
this place. Please consider moving these files to /usr/bin directly if 
they don't conflict with anything, or backuping them elsewhere.


BTW, the following is also incorrect:
if ! [ -e "/usr/X11R6/bin" ]; then
  ln -s /usr/bin /usr/X11R6/bin || die "Could not link /usr/bin to 
/usr/X11R6/bin"
fi

it should be: "ln -s ../bin /usr/X11R6/bin" instead. See policy 10.5.
-- 
 .''`.           Josselin Mouette        /\./\
: :' :           josselin.mouette@ens-lyon.org
`. `'                        joss@debian.org
  `-  Debian GNU/Linux -- The power of freedom