Re: [i915 x.org patch] suppress debugging spewage on non-i386
Now that the patch audit is complete (yay!) and I've had more time to
test the driver (mostly via xscreensaver hacks ;-)), I would like to
resubmit the following patch; as far as I can tell, there's really no
need for such debugging, particularly not mandatorily.
--------------------
As it stands, attempting to use the i915 DRI driver on non-i386
hardware (such as my EM64T system or perhaps certain ia64 systems)
produces a flood of debugging output on standard error, making the
driver relatively useless for practical purposes. The patch below,
stolen from Mesa's trunk, disables this output; I'd greatly appreciate
it if it could make its way into Debian's official packages.
(Other than that, the driver seems to work fine, and to give a visible
performance boost over the unaccelerated 3D I had with XFree86.)
For the record, the associated upstream log message was
Disable leftover debug statements
Thanks.
http://cvs.freedesktop.org/mesa/Mesa/src/mesa/drivers/dri/i915/intel_tris.c?r1=text&tr1=1.5&r2=text&tr2=1.6&makepatch=1&diff_format=u
===================================================================
RCS file: /cvs/mesa/Mesa/src/mesa/drivers/dri/i915/intel_tris.c,v
rcsdiff: /cvs/mesa/Mesa/src/mesa/drivers/dri/i915/intel_tris.c,v: warning: Unknown phrases like `commitid ...;' are present.
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- intel_tris.c 2005/05/09 17:59:13 1.5
+++ intel_tris.c 2005/05/17 22:21:08 1.6
@@ -63,9 +63,9 @@
#else
#define COPY_DWORDS( j, vb, vertsize, v ) \
do { \
- if (1) fprintf(stderr, "\n"); \
+ if (0) fprintf(stderr, "\n"); \
for ( j = 0 ; j < vertsize ; j++ ) { \
- if (1) fprintf(stderr, " -- v(%d): %x/%f\n",j, \
+ if (0) fprintf(stderr, " -- v(%d): %x/%f\n",j, \
((GLuint *)v)[j], \
((GLfloat *)v)[j]); \
vb[j] = ((GLuint *)v)[j]; \
--
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
Finger amu@monk.mit.edu (NOT a valid e-mail address) for more info.
Reply to: