[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: X Strike Force X.Org X11 SVN commit: r30 - trunk/debian



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

X Strike Force SVN Repository Admin wrote:
| Author: branden
| Date: 2005-03-10 02:25:37 -0500 (Thu, 10 Mar 2005)
| New Revision: 30
|
| Modified:
|    trunk/debian/rules
| Log:
| Add apply-patches and revert-patches targets.
|
|
| Modified: trunk/debian/rules
| ===================================================================
| --- trunk/debian/rules	2005-03-10 06:31:15 UTC (rev 29)
| +++ trunk/debian/rules	2005-03-10 07:25:37 UTC (rev 30)
| @@ -144,6 +144,51 @@
|  	  && test -d $(SOURCE_NAME)-$(UPSTREAM_VERSION) \
|  	  && tar --exclude=debian --exclude=debian/* -cf - $(SOURCE_NAME)-$(UPSTREAM_VERSION) | gzip -9
$(SOURCE_NAME)_$(UPSTREAM_VERSION).orig.tar.gz )
|
| -.PHONY: build clean make-orig-tar-gz prune-upstream-tree
| +# Apply all patches in debian/patches to the source tree.  This must be done
| +# *BEFORE* creating the Debian source package, so that all patches are reflected
| +# in the upstream part of the source tree when the .diff.gz file is generated.
| +# This is in contrast to prior xfree86 packaging, in which patches were applied
| +# at package build time.

Hi Branden,
	I know exactly why you are changing the building system, but i think
we could handle it in a slightly different way. Having apply/unpatch running
always on tree is a PITA and often leads to mistakes/problems that will leave the tree
unuseable. I suggest to keep the patches always applied and each time we add one, store it in
debian/patches in correct sequence.
If we need to recreate the patched tree, we can use the orig and apply the patches, but please
don't make it easy to trash the tree :)

Fabio

- --
Self-Service law:
The last available dish of the food you have decided to eat, will be
inevitably taken from the person in front of you.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCMTJWhCzbekR3nhgRAt7RAJ4z8/OQdr1ZkIRpYRfELRHQ7rEIIQCeLfu4
d+wwk59E+3KfABLoqXJZfKM=
=vXHX
-----END PGP SIGNATURE-----



Reply to: