On Tue, Apr 06, 2004 at 02:14:03PM +0400, Nikita V. Youshchenko wrote: > > Your patch is incomplete; there is no auto_answer counterpart for the > > "Simple" and "Medium" monitor selection methods. > > Could you please explain what you mean? Sure. > I've looked at the code of auto_answer, and I fail to find what else is > needed to change default displayed answer. > > auto_answer routine seems do put it's fourth argiment to debconf database > using db_set. So in current code it puts "Advanced" there, in my patch it > will put $DEFAULT there instead. I fail to understand why this is not > enough. Nothing else is needed to change the default displayed answer, but you need to be able to handle the later consequences. I am referring to the large case statement at line 990 of xserver-xfree86.config.in[1]. The Simple) and Medium) cases have no auto-answer logic. Your patch should not be applied until they do. [1] svn cat svn://necrotic.deadbeast.net/xfree86/trunk/debian/xserver-xfree86.config.in -- G. Branden Robinson | Religion consists in a set of Debian GNU/Linux | things which the average man thinks branden@debian.org | he believes and wishes he was http://people.debian.org/~branden/ | certain of. -- Mark Twain
Attachment:
signature.asc
Description: Digital signature