[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities



Package: xserver-xfree86
Version: 4.3.0-7
Severity: normal
Tags: patch

xserver-xfree86.config contains the following code:

...

if [ "$RET" = "true" ]; then
  db_subst xserver-xfree86/config/monitor/selection-method choices "Medium, Advanced"
  db_subst xserver-xfree86/config/monitor/selection-method default "Medium"
else # not an LCD
  db_subst xserver-xfree86/config/monitor/selection-method choices "Simple, Medium, Advanced"
  db_subst xserver-xfree86/config/monitor/selection-method default "Simple"
fi

auto_answer db_input "$(priority_ceil $PRIORITY)" xserver-xfree86/config/monitor/selection-method "Advanced"

...

Thus default answer for xserver-xfree86/config/monitor/selection-method
is "Simple" or "Medium" (which is good for non-technical users), but if
debconf actually asks the question, the default shown answer is
hardcoded to "Advanced". Since users tend to accept all defaults they
see (even after a help screen was shown describing what the selections
mean), too often they select this default and are faced with questions
about frequences they can't understand. And even can't go back at that
point.

So it seems better to show a "silly-safe" choise by default. I.e. the
same as is set in the case when question is not asked.

--- xserver-xfree86.config.orig	2004-04-05 16:02:07.000000000 +0400
+++ xserver-xfree86.config	2004-04-05 16:06:21.000000000 +0400
@@ -1568,13 +1568,14 @@
 MONITOR_IS_LCD="$RET"
 if [ "$RET" = "true" ]; then
   db_subst xserver-xfree86/config/monitor/selection-method choices "Medium, Advanced"
-  db_subst xserver-xfree86/config/monitor/selection-method default "Medium"
+  DEFAULT="Medium"
 else # not an LCD
   db_subst xserver-xfree86/config/monitor/selection-method choices "Simple, Medium, Advanced"
-  db_subst xserver-xfree86/config/monitor/selection-method default "Simple"
+  DEFAULT="Simple"
 fi
 
-auto_answer db_input "$(priority_ceil $PRIORITY)" xserver-xfree86/config/monitor/selection-method "Advanced"
+db_subst xserver-xfree86/config/monitor/selection-method default $DEFAULT
+auto_answer db_input "$(priority_ceil $PRIORITY)" xserver-xfree86/config/monitor/selection-method $DEFAULT
 
 db_get xserver-xfree86/config/monitor/selection-method
 case "$RET" in



Reply to: