On Fri, Feb 20, 2004 at 01:06:43AM +0100, Filip Van Raemdonck wrote: > On Thu, Feb 19, 2004 at 01:04:03PM -0500, Branden Robinson wrote: > > > > Hmm, yup. I didn't give the second fgrep a second argument. The first > > fgrep will never block waiting on STDIN. > > > > Thanks for catching this. I'll fix it right away. > > IME (I could be wrong, just messed around 'til I got dpkg exiting cleanly) > you have to drop the -q arg (this also makes sense if I read the function > correctly - I hope I am ;) and add an " || true" after that fgrep because > the maintainer script will otherwise almost always exit with an error code > (fgrep returning non-zero if /usr/X11R6/lib is the only directory listed > in ld.so.conf). Yup. Thanks a *lot* for the code review. Both of these issues will be fixed in 4.3.0-3 as well. > BTW. Thanks for the work on Debian - while I like whatever I do whenever > I get around to do it myself, I do love it when I get some appreciation, > whenever someone sends it. I think anyone working on X11 packages needs > it even more so than I do :) > (maybe we should propose a debian-love ML, just like gnome-love >:-) It'd be a nice counterweight to debian-flame, er, debian-devel. :) -- G. Branden Robinson | If you don't think for yourself, Debian GNU/Linux | others will think for you -- to branden@debian.org | their advantage. http://people.debian.org/~branden/ | -- Harold Gordon
Attachment:
signature.asc
Description: Digital signature