Bug#286043: xfs: init.d scrip has bad "test[]" paramiters.
package xfs
close 286043
merge 286043 285133
thanks
On Friday, December 17, 2004 3:33 AM, Mike Mestnik) (the Archmage forever
<cheako@filbert.is-a-geek.org> wrote:
> Package: xfs
> Version: 4.3.0.dfsg.1-9
> Severity: normal
>
> Line 24 of /etc/init.d/xfs should read...
> if [ -e $SOCKET_DIR -a ! -d $SOCKET_DIR ]; then
> and not...
> if [ -e $SOCKET_DIR && [ ! -d $SOCKET_DIR ]; then
> The latter is clearly missing an ']'.
Indeed, but the proper way to correct it would be to add the ']', not to
make the test non-POSIX-compliant. :-)
if [ -e $SOCKET_DIR ] && [ ! -d $SOCKET_DIR ]; then
(possibly quoting $SOCKET_DIR if there's any chance of it being empty).
In fact, that's exactly what was done in 4.3.0.dfsg.1-10, to close the
previous report of this bug (#285133). Closing this report as the fixed
packages are already in the archive (and will be on mirrors once the daily
pulse is fixed).
Regards,
Adam
Reply to: