[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#268116: marked as done (xfree86: may FTBFS if current locale makes sort ordering differ)



Your message dated Sat, 28 Aug 2004 00:51:15 -0500
with message-id <20040828055115.GC20103@redwald.deadbeast.net>
and subject line fixed bug
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 26 Aug 2004 06:38:04 +0000
>From guillem@gluck.debian.org Wed Aug 25 23:38:04 2004
Return-path: <guillem@gluck.debian.org>
Received: from gluck.debian.org [192.25.206.10] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1C0Dtb-0005LU-00; Wed, 25 Aug 2004 23:38:04 -0700
Received: from guillem by gluck.debian.org with local (Exim 3.35 1 (Debian))
	id 1C0DtT-00074a-00; Thu, 26 Aug 2004 00:38:01 -0600
Date: Thu, 26 Aug 2004 08:36:35 +0200
From: Guillem Jover <guillem@debian.org>
To: submit@bugs.debian.org
Subject: xfree86: may FTBFS if current locale makes sort ordering differ
Message-ID: <20040826063635.GA21363@zulo.hadrons.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="opJtzjQTFsWo+cga"
Content-Disposition: inline
User-Agent: Mutt/1.5.6+20040818i
Sender: Guillem Jover <guillem@gluck.debian.org>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.4 required=4.0 tests=BAYES_00,HAS_PACKAGE,
	UPPERCASE_25_50 autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 


--opJtzjQTFsWo+cga
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Package: xfree86
Version: 4.3.0.dfsg.1-6+SVN (r1741)
Severity: important
Tags: patch

Hi,

While building r1741 to test the patch on #260099, I got a FTBFS in
the MANIFEST check. The problem here is that one sort uses LC_ALL=C
and the others does not, so if the current locale is different from C
it will use a differenr sorting order.

On my build system I had LANG=C, LC_COLLATE=ca_ES and LC_CTYPE=ca_ES.

Attached is a trivial patch (against trunk's HEAD) that solves this
possible problem, thus not RC severity, although I think it should
get into -6.

regards,
guillem

--opJtzjQTFsWo+cga
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="xfree86-4.3.0.dfsg.1-6+SVN_FTFBS_locale_sort.patch"

Index: rules
===================================================================
--- rules	(revision 1755)
+++ rules	(working copy)
@@ -352,12 +352,12 @@
 	# Construct MANIFEST files from MANIFEST.$(ARCH).in and
 	# MANIFEST.$(ARCH).all or MANIFEST.all.
 	if expr "$(findstring -DBuildFonts=NO,$(IMAKE_DEFINES))" : "-DBuildFonts=NO" >/dev/null 2>&1; then \
-	  sort -u debian/MANIFEST.$(ARCH).in >debian/MANIFEST.$(ARCH); \
+	  LC_ALL=C sort -u debian/MANIFEST.$(ARCH).in >debian/MANIFEST.$(ARCH); \
 	else \
 	  if [ -e debian/MANIFEST.$(ARCH).all ]; then \
-	    sort -u debian/MANIFEST.$(ARCH).in debian/MANIFEST.$(ARCH).all >debian/MANIFEST.$(ARCH); \
+	    LC_ALL=C sort -u debian/MANIFEST.$(ARCH).in debian/MANIFEST.$(ARCH).all >debian/MANIFEST.$(ARCH); \
 	  else \
-	    sort -u debian/MANIFEST.$(ARCH).in debian/MANIFEST.all >debian/MANIFEST.$(ARCH); \
+	    LC_ALL=C sort -u debian/MANIFEST.$(ARCH).in debian/MANIFEST.all >debian/MANIFEST.$(ARCH); \
 	  fi; \
 	fi
 	# confirm that the installed file list has not changed

--opJtzjQTFsWo+cga--

---------------------------------------
Received: (at 268116-done) by bugs.debian.org; 28 Aug 2004 05:51:17 +0000
>From branden@redwald.deadbeast.net Fri Aug 27 22:51:17 2004
Return-path: <branden@redwald.deadbeast.net>
Received: from dhcp065-026-182-085.indy.rr.com (sisyphus.deadbeast.net) [65.26.182.85] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1C0w7R-000165-00; Fri, 27 Aug 2004 22:51:17 -0700
Received: by sisyphus.deadbeast.net (Postfix, from userid 1000)
	id 9C04968C002; Sat, 28 Aug 2004 00:51:15 -0500 (EST)
Date: Sat, 28 Aug 2004 00:51:15 -0500
From: Branden Robinson <branden@debian.org>
To: 268116-done@bugs.debian.org
Subject: fixed bug
Message-ID: <20040828055115.GC20103@redwald.deadbeast.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="vGgW1X5XWziG23Ko"
Content-Disposition: inline
User-Agent: Mutt/1.5.6+20040803i
Delivered-To: 268116-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
	version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 


--vGgW1X5XWziG23Ko
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

I fixed this bug in SVN r1756.

Since this bug was never actually any Debian package release (not even to
unstable), I'm closing it immediately.

Thanks for diagnosing this problem, Guillem; I had no idea what was causing
Fabio's trouble, and was totally stumped.

--=20
G. Branden Robinson                |       Psychology is really biology.
Debian GNU/Linux                   |       Biology is really chemistry.
branden@debian.org                 |       Chemistry is really physics.
http://people.debian.org/~branden/ |       Physics is really math.

--vGgW1X5XWziG23Ko
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iEYEARECAAYFAkEwHVMACgkQ6kxmHytGonzhOACfVhdH8//XYAsC/wSSZLLShGUP
yYsAnjy7n4ywJPG4QxrAAZNYK3RSYZJn
=XDh1
-----END PGP SIGNATURE-----

--vGgW1X5XWziG23Ko--



Reply to: