Bug#229850: DEFAULT_HORIZ_SYNC and DEFAULT_VERT_REFRESH still ignored (updated patch)

[Jay Berkenbilt <ejb@ql.org>]

severity 229850 important
thanks

Hello again.  As a reminder, the point of this bug is that the
xserver-xfree86 config script uses get-edid to determine the monitor's
horizontal sync and vertical refresh rates, and then discards the
information.  The fix I'm suggesting is fairly obvious and simple.
The config script as it stands now actually detects safely whether or
not the monitor has returned this information and assign the results
to the variables DEFAULT_HORIZ_SYNC and DEFAULT_VERT_REFRESH, but then
it never again uses those values, instead using the hard-coded ranges
that are originally assigned.  The code clearly takes a different path
when this information is available as if it the original intention was
to use this information.  My patch just changes the code to actually
use those values.

I have configured a handful of systems with different types of
hardware using this patch.  In all cases, without this patch, I end up
with sync/refresh rates that are too low, and with this patch, I end
up with correct values.  I have upgraded the importance of this bug
from normal to important because I believe that, without this patch,
the X server configuration in sarge will continue to generate
suboptimal XFree86 configuration files that don't take advantage of
the capabilities of people's monitors.  Some people, myself included,
have a very hard time looking at a monitor whose refresh rate is too
low, and this is the result of not having this problem fixed.  Note
that with this patch applied, configuring xserver-xfree86 with debconf
priority "medium" generates an optimal XFree86-Config-4 file in all
cases I've tested.

I notice that the config script for xserver-xfree86 has been
extensively modified since I originally made this report, so I have
decided to resubmit my patch.  This time, I have created the patch so
that it would apply to the extracted source package.  Hopefully this
will make it easier to handle.

I truly hope you will consider including this simple patch in time for
sarge.  I think it will really improve the way people's X displays
will look and help to make Debian a better distribution. :-)

-- 
Jay Berkenbilt <ejb@ql.org>
http://www.ql.org/q/

--- debian/xserver-xfree86.config.in.orig	2004-08-02 20:27:32.000000000 -0400
+++ debian/xserver-xfree86.config.in	2004-08-02 20:38:16.000000000 -0400
@@ -1231,8 +1231,8 @@
     esac
     ;;
   Advanced)
-    auto_answer validate_monitor_frequency_db_input "$(priority_ceil $PRIORITY)" xserver-xfree86/config/monitor/horiz-sync "28-50"
-    auto_answer validate_monitor_frequency_db_input "$(priority_ceil $PRIORITY)" xserver-xfree86/config/monitor/vert-refresh "43-75"
+    auto_answer validate_monitor_frequency_db_input "$(priority_ceil $PRIORITY)" xserver-xfree86/config/monitor/horiz-sync $DEFAULT_HORIZ_SYNC
+    auto_answer validate_monitor_frequency_db_input "$(priority_ceil $PRIORITY)" xserver-xfree86/config/monitor/vert-refresh $DEFAULT_VERT_REFRESH
     ;;
 esac