[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: description of fix for #230204 for clean-room reimplmentation



On Wed, Apr 21, 2004 at 08:36:19PM -0700, Keith Packard wrote:
> 
> Around 16 o'clock on Apr 21, Branden Robinson wrote:
> 
> > In the source file
> > <xc/programs/Xserver/hw/xfree86/os-support/linux/lnx_io.c>:
> 
> I'll note that the version of KDKBDREP_ioctl_ok in X.Org CVS does:
> 
> static int
> KDKBDREP_ioctl_ok(int rate, int delay) {
> #if defined(KDKBDREP) && !defined(__sparc__)
>      /* This ioctl is defined in <linux/kd.h> but is not
>         implemented anywhere - must be in some m68k patches. */

the ifndef __sparc__ here is totally bogus as the code is in the
generic vt code and enabled for all architectures.  similarly the
comment is rather strange.  Might be best to just removed them..



Reply to: