[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

description of fix for #230204 for clean-room reimplmentation



On Wed, Apr 21, 2004 at 12:19:42PM -0700, Keith Packard wrote:
> 
> Around 14 o'clock on Apr 21, Branden Robinson wrote:
> 
> > Also, if there is a C programmer present who is willing to perform such
> > a clean-room rewrite should it come to that, please speak up.
> 
> I can do that.

Here's a description of the change in question.

In the source file
<xc/programs/Xserver/hw/xfree86/os-support/linux/lnx_io.c>:

* Change the KDKBDREP_ioctl_ok() function definition to accept a file
  descriptor argument in addition to the arguments it already accepts.

* When performing a KDKBDREP ioctl() in this function, perform the
  ioctl() on the file descriptor passed in, not on fd 0.

* In the function xf86SetKbdRepeat(), change the invocation of
  KDKBDREP_ioctl_ok() to conform to the new function definition, passing
  in a file descriptor.  The file descriptor for the console device can
  be retrieved from the xf86InfoRec structure, which is defined in
  <xc/programs/Xserver/hw/xfree86/common/xf86Privstr.h>.  Note that the
  console file descriptor is accessed by other functions in this source
  file, such as xf86SoundKbdBell(), defined at the top of the file.

Make identical changes to
<xc/programs/Xserver/hw/xfree86/os-support/linux/lnx_kbd.c>.

(Observation: The function KDKBDREP_ioctl_ok() does not appear to be
prototyped anywhere.)

-- 
G. Branden Robinson                |     What influenced me to atheism was
Debian GNU/Linux                   |     reading the Bible cover to cover.
branden@debian.org                 |     Twice.
http://people.debian.org/~branden/ |     -- J. Michael Straczynski

Attachment: signature.asc
Description: Digital signature


Reply to: