Bug#148775: Tested patch
tags 148775 + patch
thanks
Michel, your suggestion was right.
Here's an amendment to 022_r128_driver_pitch_tweak.diff (TPFKA #069)
that changes the r128 Xvideo driver to use a granularity of 8 as well.
I have tested it on the original triggering scenario and Xvideo works.
Is it perhaps time to submit this patch upstream now?
--
ilmari
Index: patches/022_r128_driver_pitch_tweak.diff
===================================================================
--- patches/022_r128_driver_pitch_tweak.diff (revision 965)
+++ patches/022_r128_driver_pitch_tweak.diff (working copy)
@@ -1,6 +1,7 @@
$Id$
This patch by Branden Robinson after consultation with Michel Dänzer.
+Xv patch by Dagfinn Ilmari Mannsåker after suggestion by Michel Dänzer.
Not submitted upstream yet.
@@ -19,3 +20,30 @@
128, /* minHeight */
2048, /* maxHeight */
pScrn->display->virtualX,
+diff -ruN xc-old/programs/Xserver/hw/xfree86/drivers/ati/r128_video.c xc/programs/Xserver/hw/xfree86/drivers/ati/r128_video.c
+--- xc-old/programs/Xserver/hw/xfree86/drivers/ati/r128_video.c 2003-02-19 02:19:41.000000000 +0100
++++ xc/programs/Xserver/hw/xfree86/drivers/ati/r128_video.c 2004-01-22 23:51:43.000000000 +0100
+@@ -694,20 +694,20 @@
+
+ pScreen = screenInfo.screens[pScrn->scrnIndex];
+
+- new_linear = xf86AllocateOffscreenLinear(pScreen, size, 16,
++ new_linear = xf86AllocateOffscreenLinear(pScreen, size, 8,
+ NULL, NULL, NULL);
+
+ if(!new_linear) {
+ int max_size;
+
+- xf86QueryLargestOffscreenLinear(pScreen, &max_size, 16,
++ xf86QueryLargestOffscreenLinear(pScreen, &max_size, 8,
+ PRIORITY_EXTREME);
+
+ if(max_size < size)
+ return NULL;
+
+ xf86PurgeUnlockedOffscreenAreas(pScreen);
+- new_linear = xf86AllocateOffscreenLinear(pScreen, size, 16,
++ new_linear = xf86AllocateOffscreenLinear(pScreen, size, 8,
+ NULL, NULL, NULL);
+ }
+
Reply to: