Re: X Strike Force SVN commit: rev 555 - in branches/4.3.0/sid/debian: . patches
Branden Robinson wrote:
> On Fri, Sep 19, 2003 at 01:36:38PM -0500, X Strike Force SVN Admin wrote:
>> Author: wt
>> Date: 2003-09-19 13:36:17 -0500 (Fri, 19 Sep 2003)
>> New Revision: 555
>>
>> Added:
>> branches/4.3.0/sid/debian/patches/017_x11_pkg_config_enable.diff
>> Removed:
>> branches/4.3.0/sid/debian/patches/017_fix_Xlib_depend_target.diff
>> Modified:
>> branches/4.3.0/sid/debian/MANIFEST.i386
>> branches/4.3.0/sid/debian/rules
>> branches/4.3.0/sid/debian/xlibs-dev.install
>> Log:
>> Enabling pkg-config for libX11. The main artifact is that
>> there is now a file called /usr/lib/pkgconfig/X11.pc.
>
> This commit was defective, in my opinion.
>
> In the future, please do not alter a MANIFEST file without altering all
> of them, when the change being made is expected to affect all
> architectures. If the change affects only some architectures, update
> the MANIFEST files exactly as you expect them to change.
Okay, I was just under the impression that that should be done by someone on
the arch...sorry.
> Also, don't use the same patch number for a radical alteration of the
> patch's function. It would have been better to delete patch #017 and
> add the new patch at the first available number, which is somewhere
> around #070, I think.
Okay, gotcha.
wt
--
President, GOLUM, Inc.
http://www.golum.org
Reply to: