[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#66848: marked as done (xlibs: [libX11] endless loop in XlibInt.c:_XFlushInt())



Your message dated Tue, 2 Sep 2003 05:48:40 -0500
with message-id <20030902104840.GE6169@deadbeast.net>
and subject line #66848: xlibs: Multithreading problem in xlibs
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 7 Jul 2000 04:46:30 +0000
>From dpotapov@capitalsoft.com Thu Jul 06 23:46:30 2000
Return-path: <dpotapov@capitalsoft.com>
Received: from ns.mtu.ru (mtu.ru) [195.34.32.10] 
	by master.debian.org with esmtp (Exim 3.12 2 (Debian))
	id 13AQ21-00082i-00; Thu, 06 Jul 2000 23:46:29 -0500
Received: from potapov.private (ppp96-92.dialup.mtu-net.ru [212.188.96.92])
	by mtu.ru (Postfix) with ESMTP id 70CFA475A
	for <submit@bugs.debian.org>; Fri,  7 Jul 2000 08:46:26 +0400 (MSD)
	(envelope-from dpotapov@capitalsoft.com)
Received: (from dpotapov@localhost)
	by potapov.private (8.9.3/8.9.3/Debian 8.9.3-21) id IAA00792
	for submit@bugs.debian.org; Fri, 7 Jul 2000 08:43:38 +0400
Date: Fri, 7 Jul 2000 08:43:38 +0400
From: Dmitry Potapov <dpotapov@capitalsoft.com>
To: submit@bugs.debian.org
Subject: Multithreading problem in xlib6g
Message-ID: <20000707084338.A626@potapov.private>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
User-Agent: Mutt/1.0.1i
X-Recipient: submit@bugs.debian.org
Delivered-To: submit@bugs.debian.org

Package: xlib6g
Version: 3.3.6-8

I discover this problem when use Netscape.
Some time Netscape hang with 100% CPU usage.
I look on code and find that it make infinity loop
inside XlibInc.c file:

#ifdef XTHREADS
        while (dpy->flags & XlibDisplayWriting) {
            ConditionWait(dpy, dpy->lock->writers);
        }
#endif

where ConditionWait defined in locking.h as

#define ConditionWait(d,c) if ((d)->lock) \
        (*(d)->lock->condition_wait)(c, (d)->lock->mutex)

So when (d)->lock is null then program have no chance to
leave while loop.

This problem already fixed more new version of X11 
(at least in 4.0.1). So there is patch:

--- XlibInt.c.orig	Sat Jul  1 14:17:42 2000
+++ XlibInt.c	Fri Jul  7 08:09:53 2000
@@ -605,7 +605,11 @@
        }
 #ifdef XTHREADS
 	while (dpy->flags & XlibDisplayWriting) {
-	    ConditionWait(dpy, dpy->lock->writers);
+	    if (dpy->lock) {
+		ConditionWait(dpy, dpy->lock->writers);
+	    } else {
+		_XWaitForWritable (dpy, cv);
+	    }
 	}
 #endif
 	size = todo = dpy->bufptr - dpy->buffer;


Thanks,
Dmitry

---------------------------------------
Received: (at 66848-done) by bugs.debian.org; 2 Sep 2003 10:48:43 +0000
>From branden@deadbeast.net Tue Sep 02 05:48:41 2003
Return-path: <branden@deadbeast.net>
Received: from dhcp065-026-182-085.indy.rr.com (redwald.deadbeast.net) [65.26.182.85] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 19u8iH-0006E1-00; Tue, 02 Sep 2003 05:48:41 -0500
Received: by redwald.deadbeast.net (Postfix, from userid 1000)
	id 6645964120; Tue,  2 Sep 2003 05:48:40 -0500 (EST)
Date: Tue, 2 Sep 2003 05:48:40 -0500
From: Branden Robinson <branden@debian.org>
To: 66848-done@bugs.debian.org
Subject: Re: #66848: xlibs: Multithreading problem in xlibs
Message-ID: <20030902104840.GE6169@deadbeast.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="9l24NVCWtSuIVIod"
Content-Disposition: inline
User-Agent: Mutt/1.5.4i
Delivered-To: 66848-done@bugs.debian.org
X-Spam-Status: No, hits=-6.3 required=4.0
	tests=BAYES_20,PENISACCENT,PGP_SIGNATURE_2,USER_AGENT_MUTT
	version=2.53-bugs.debian.org_2003_8_27
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_8_27 (1.174.2.15-2003-03-30-exp)


--9l24NVCWtSuIVIod
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

This bug was fixed upstream a while ago.

An inspection of the source reveals that it is certainly fixed in
XFree86 4.2.1, currently in Debian testing and unstable.

Closing this bug.

--=20
G. Branden Robinson                |    A celibate clergy is an especially
Debian GNU/Linux                   |    good idea, because it tends to
branden@debian.org                 |    suppress any hereditary propensity
http://people.debian.org/~branden/ |    toward fanaticism.    -- Carl Sagan

--9l24NVCWtSuIVIod
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iEYEARECAAYFAj9UdYcACgkQ6kxmHytGonygEgCeORG2PvtNSUnnuicC2sDPmlbv
Tq8Ani6dEBw7urDNoufO/3hhCgqG4vu/
=aWE0
-----END PGP SIGNATURE-----

--9l24NVCWtSuIVIod--



Reply to: