[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Postinst bus ID regexp in 4.2.1-0pre1v1



On Thu, Sep 12, 2002 at 09:11:35AM +0200, Chris Halls wrote:
> Where "bustype" is "PCI" for PCI and AGP video cards, and each of "bus",
> "device", and "function" is a decimal (not hexadecimal) value.  For example,
> "PCI:0:16:0" is valid input (without the double-quotes).
>  ^^^^^^^^^^
[...]
> Since a 1 digit number is valid config syntax, could you change \+ to \? please?

Well, how about this?

    if [ -z "$RET" ] || expr "$RET" : "[A-Z]\+:[0-9]\{1,3\}:[0-9]\{1,3\}:[0-9]\{1,3\}$" > /dev/null 2>&1; then

  * debian/xserver-xfree86.config.in: tweak validation of BusID specifications
    to permit exactly one to three digits in each field of a PCI bus spec

-- 
G. Branden Robinson                |      "There is no gravity in space."
Debian GNU/Linux                   |      "Then how could astronauts walk
branden@debian.org                 |       around on the Moon?"
http://people.debian.org/~branden/ |      "Because they wore heavy boots."

Attachment: pgp5YeN3vUX67.pgp
Description: PGP signature


Reply to: