[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Postinst bus ID regexp in 4.2.1-0pre1v1



Hi,

I thought I'd give the 4.2.1-0pre1v1 autoconfigure a run on one of my
machines to see how it is getting on.  It got stuck at the question about
the bus ID of the card, refusing to accept my input as valid, even if I
tried the example given:

Where "bustype" is "PCI" for PCI and AGP video cards, and each of "bus",
"device", and "function" is a decimal (not hexadecimal) value.  For example,
"PCI:0:16:0" is valid input (without the double-quotes).
 ^^^^^^^^^^

I dug around in the postinst and found this regexp which validates the
input:

  if [ -z "$RET" ] || expr "$RET" : "[A-Z]\+:[0-9][0-9]\+:[0-9][0-9]\?:[0-9][0-9]\?$" > /dev/null 2>&1
                                                       ^^

That wants to see a 2 digit number in the first number, i.e. PCI:00:16:0

Since a 1 digit number is valid config syntax, could you change \+ to \? please?

Thanks,
Chris

Attachment: pgpePKfqyE_9X.pgp
Description: PGP signature


Reply to: