[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: useful topics and commit messages within git commits on webwml repository

Is there a problem?
These are Korean translations.
I'm Korean tranlation coordinator.
Who can help Korean translation ?

Thank you.

On Sat, Feb 22, 2020, 18:02 Carsten Schoenert <c.schoenert@t-online.de> wrote:
Hello Sebul,

I noticed you constantly use only one word for documenting your commits
within the webwml repository. E.g.

> $ git show 7dc100 b9aab8 bdeee6 --shortstat
> commit 7dc1005a769339b4d37a2a661f73ee197edaece1
> Author: Sebul <sebuls@gmail.com>
> Date:   Sat Feb 22 14:21:18 2020 +0900
>     4631
>  1 file changed, 23 insertions(+)
> commit b9aab8bf143922068d02cdc835908a062944914c
> Author: Sebul <sebuls@gmail.com>
> Date:   Wed Feb 19 21:28:12 2020 +0900
>     8
>  1 file changed, 20 insertions(+)
> commit bdeee6693fc19bcd7cdca2caf399771344796848
> Author: Sebul <sebuls@gmail.com>
> Date:   Wed Feb 19 21:25:58 2020 +0900
>     webkit
>  1 file changed, 47 insertions(+)

This kind of doing commits makes it nearly impossible to follow and
understand the additions you are doing. Everybody needs to have also a
look into the details of your commit to see what you have done. That's
bad because it's costs time on the others side, by this it makes the
work other people do more inefficient.
The current way you doing commit messages makes the usage of the git log
command useless.

Could you please adjust your workflow in the future to make an useful
usage of the topic/subject and if needed of the body of the git commit?
Thanks for consideration!

For example you could use one of the following stanza for the subject
(as other contributors already doing so).

(Korean) DSA-4631-1 pillow
(ko) [DSA 4631-1] pillow security update

Carsten Schoenert

Reply to: