[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#754601: [www] tidy reports errors on release pages

Dear victory and Laura,

At Sun, 13 Jul 2014 07:03:04 +0900,
victory wrote:
> what it reports are nested strong elements and undefined
>  small-non-free-cd-images element.
> on the squeeze page, entire <div class="line"> block is useless

I have some comments about your patch.

> [2 tidy-release.txt <text/plain (7bit)>]
> Index: squeeze/debian-installer/index.wml
> ===================================================================
> --- squeeze/debian-installer/index.wml	(revision 103)
> +++ squeeze/debian-installer/index.wml	(working copy)
> @@ -78,14 +78,7 @@
>  and general information about loading firmware during an installation can
>  be found in the Installation Guide (see Documentation below).
>  </p>
> -<div class="line">
> -<div class="item col50">
> -<p><strong>netinst (generally 175-240 MB) <strong>non-free</strong>
> -CD images <strong>with firmware</strong></strong></p>
> -<small-non-free-cd-images />
>  </div>
> -</div>
> -</div>

1. <div class="line"> and <div class="item col50"> block

The role of these blocks is essential in terms of look and feel.
I don't think it should be removed.

2. small-non-free-cd-images element

This WML tag is prepared to generate a list of netinst non-free CD images
and the images are available on cdimage.debian.org.
As you pointed out before, since the WML tag is not defined, wml keeps it as is.
I think a functionality of the tag should be implemented
instead of removing the tag.

> Index: wheezy/debian-installer/index.wml
> ===================================================================
> --- wheezy/debian-installer/index.wml	(revision 103)
> +++ wheezy/debian-installer/index.wml	(working copy)
> @@ -89,8 +89,8 @@
>  </p>
>  <div class="line">
>  <div class="item col50">
> -<p><strong>netinst (generally 240-290 MB) <strong>non-free</strong>
> -CD images <strong>with firmware</strong></strong></p>
> +<p><strong>netinst (generally 240-290 MB) non-free
> +CD images with firmware></strong></p>
>  <small-non-free-cd-images />
>  </div>
>  </div>

3. nested strong elements

According to the DTD of HTML 4.01 [1] and XHTML1 [2],
strong elements is allowed to be nested.
Moreover, for HTML5 (which might be the next-generation web standard),
you can increase the level of importance by nesting of strong element[2].
I don't know when Debian migrate from HTML 4.01 to XHTML1 [3] or HTML5.
But, we should always perform modification with loosing meaning
in a careful manner (in terms of respecting original work),
and I think we should keep it as is.

[1] https://www.w3.org/TR/html4/sgml/dtd.html#phrase
[2] https://www.w3.org/TR/xhtml1/dtds.htm
[3] https://www.debian.org/devel/website/desc.en.html
[4] https://www.w3.org/TR/html5/text-level-semantics.html#the-strong-element

At Fri, 3 Jun 2016 06:11:19 +0900,
victory wrote:
> > I think the problem is solved, closing this bug.
> no
> it excludes pages under release/ by the line below;
> ie.: what you subscribed, never reports actual error in these pages

Following points mentioned above,
I modified some files in webwml CVS repository
and committed a patch to fix small-non-free-cd-images problem.
Now, it looks good for me (nesting of strong element is not fixed)
and I think it is OK to close this bug.

What do you think of generated HTML pages [1,2,3]?
Do you still think there still are some problems we should fix?

[1] https://www.debian.org/releases/squeeze/debian-installer/index.en.html
[2] https://www.debian.org/releases/wheezy/debian-installer/index.en.html
[3] https://www.debian.org/releases/jessie/debian-installer/index.en.html

Sincerely yours,
Ryuunosuke Ayanokouzi
AYANOKOUZI, Ryuunosuke <i38w7i3@yahoo.co.jp>

Attachment: pgpBGdiXC07zH.pgp
Description: OpenPGP Digital Signature

Reply to: