Re: Access to www-master? (Was: Re: Plan to commit changed vote tree and new CD menu)
* Matt Kraai <kraai@ftbfs.org> [2005-11-30 06:59] :
> On Wed, Nov 30, 2005 at 10:07:43AM +0100, Frédéric Bothamy wrote:
> > * Frédéric Bothamy <frederic.bothamy@free.fr> [2005-11-28 13:39] :
> > > * Jutta Wrage <jw@witch.westfalen.de> [2005-11-25 02:07] :
> > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > Hash: SHA1
> > > >
> > > >
> > > > Am 24.11.2005 um 22:19 schrieb Frédéric Bothamy:
> > > >
> > > > >"Download" in the menu be translatable to other languages?
> > > >
> > > > Everything translatable now, I think. And everything commited.
> > >
> > > Thanks for your help!
> > >
> > > Unfortunately, the menu on CD/ (and the titles on vote/) is not
> > > translated even though I have updated the templates po file for French
> > > (correctly, I believe).
> > >
> > > I think that the .mo files were not regenerated after my changes (at
> > > least, I can reproduce the problem this way). Could anyone have a look
> > > on www-master and check the datestamp for the .mo files wrt to the po
> > > files?
> >
> > It seems my message went unnoticed. Could anyone with access to
> > www-master check this as the problem exposed is still not fixed? Or if
> > possible explain me how I can check this myself (knowing that I am not a
> > DD)?
>
> -rw-rw-r-- 1 debwww webwml 19777 Nov 27 19:46 locale/fr/LC_MESSAGES/templates.mo
> -rw-r--r-- 1 debwww webwml 36620 Nov 27 19:30 french/po/templates.fr.po
>
> I don't know how to check whether the .mo file contains the right
> translations.
Since the size matches with my own templates.mo file, it may be correct
(you could either rebuild the mo file to regenerate it or compare the
md5sum, you could even strings the mo file and check that the latest
added strings are there).
But I may have found the bug: the english/CD/Makefile does not declare a
dependency on templates.mo as it should (same for
english/vendors/Makefile). So I guess that the translations are not
updated when the .mo files are changed (I am still checking whether this
is true or not).
The patch for this issue would be:
Index: CD/Makefile
===================================================================
RCS file: /cvs/webwml/webwml/english/CD/Makefile,v
retrieving revision 1.9
diff -u -u -r1.9 Makefile
--- CD/Makefile 26 Jul 2004 18:19:41 -0000 1.9
+++ CD/Makefile 30 Nov 2005 17:04:19 -0000
@@ -9,6 +9,7 @@
NOGENERICDEP := true
include $(WMLBASE)/Make.lang
+GETTEXTFILES += templates.mo
ifneq "$(wildcard releases/index.wml)" ""
RELEASESDEP := releases/index.wml
Index: vote/Makefile
===================================================================
RCS file: /cvs/webwml/webwml/english/vote/Makefile,v
retrieving revision 1.21
diff -u -u -r1.21 Makefile
--- vote/Makefile 6 May 2005 19:22:00 -0000 1.21
+++ vote/Makefile 30 Nov 2005 17:04:19 -0000
@@ -8,6 +8,7 @@
include $(WMLBASE)/Make.lang
+GETTEXTFILES += templates.mo
index.$(LANGUAGE).html: index.wml \
$(wildcard $(ENGLISHSRCDIR)/$(CUR_DIR)/[0-9]*/vote_*.wml) \
Can anyone confirm this issue and its solution?
Fred
Reply to: