[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: invalid numeric character reference 149



Le vendredi  6 mai 2005, Jens Seidel écrit :
> On Fri, May 06, 2005 at 06:53:58PM +0200, Frank Lichtenheld wrote:
> > On Thu, May 05, 2005 at 08:13:57PM +0200, Nicolas Bertolissio wrote:
> > > Thanks, I also read a part of the GNU Make manual and created the right
> > > targets, this is committed now and next rebuild will fix the troubles.
> 
> Thanks, this was indeed missing.
>  
> > Hmm, that's probably not enough. I think all files also need to depend
> > on all other files since the votebar can change if any of the vote files
> > changes...
> 
> Nicolas, your patch included:
> 
> Index: vote/2002/platforms/Makefile
> ===================================================================
> RCS file: /cvs/webwml/webwml/english/vote/2002/platforms/Makefile,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- vote/2002/platforms/Makefile	27 Feb 2002 19:34:43 -0000	1.1
> +++ vote/2002/platforms/Makefile	6 May 2005 15:57:05 -0000	1.2
> @@ -8,5 +8,8 @@
>  
>  include $(WMLBASE)/Make.lang
>  
> +index.$(LANGUAGE).html: index.wml \
> +  $(TEMPLDIR)/template.wml $(TEMPLDIR)/votebar.wml
> +
>  index.$(LANGUAGE).html: index.wml $(wildcard vote_*.wml) \
>    $(TEMPLDIR)/template.wml $(TEMPLDIR)/recent_list.wml

[...]

> Nevertheless I doubt that it is necessary to write two
> index.$(LANGUAGE).html rules. It should be save to merge both and since
> $(wildcard vote_*.wml) expands to "" below vote/*/platforms/ this can be
> removed as well.
> 
> Please change it to:
> 
> index.$(LANGUAGE).html: index.wml $(TEMPLDIR)/template.wml \
>    $(TEMPLDIR)/votebar.wml $(TEMPLDIR)/recent_list.wml \
>    + all other dependencies according to Frank

this was a mistake, I forgot to remove the initial target, index doesn't
depend on recent_list in this subdirectory. So I'm fixing this now.

Regards


Nicolas
-- 



Reply to: