Bug#249801: marked as done (www.debian.org: tidy reports trimming empty <dd> for vote pages)
Your message dated Wed, 19 May 2004 17:43:32 -0700
with message-id <20040520004332.GB623@catalunya>
and subject line Bug#249801: www.debian.org: tidy reports trimming empty <dd> for vote pages
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 19 May 2004 10:22:06 +0000
>From nico.bertol@free.fr Wed May 19 03:22:06 2004
Return-path: <nico.bertol@free.fr>
Received: from postfix3-2.free.fr [213.228.0.169]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1BQOD7-0006c7-00; Wed, 19 May 2004 03:22:06 -0700
Received: from bertol (lns-th2-4f-81-56-240-158.adsl.proxad.net [81.56.240.158])
by postfix3-2.free.fr (Postfix) with ESMTP id AF601D53D
for <submit@bugs.debian.org>; Wed, 19 May 2004 12:22:04 +0200 (CEST)
Received: from nico by bertol with local (Exim 3.35 #1 (Debian))
id 1BQOAC-0000t2-00; Wed, 19 May 2004 12:19:04 +0200
Date: Wed, 19 May 2004 12:19:03 +0200
From: Nicolas Bertolissio <nico.bertol@free.fr>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: www.debian.org: tidy reports trimming empty <dd> for vote pages
Message-ID: <[🔎] 20040519101903.GC2341@free.fr>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="V0207lvV8h4k8FAm"
Content-Disposition: inline
X-Reportbug-Version: 2.58
User-Agent: Mutt/1.5.5.1+cvs20040105i
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=0.5 required=4.0 tests=BAYES_20,HTML_MESSAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
--V0207lvV8h4k8FAm
Content-Type: multipart/mixed; boundary="fUYQa+Pmc3FrFX/N"
Content-Disposition: inline
--fUYQa+Pmc3FrFX/N
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Package: www.debian.org
Severity: normal
Tags: patch
Hi,
looking at
http://people.debian.org/~alfie/tidy/fr
tidy reports some warning about empty <dd> tags, here is a patch that
should solve this problem for vote pages, where in fact it is the only
case where there is nothing between the two variable
$elemfoot$elemrealfoot in the wml code, the new variable $elememptyfoot
should be used each time the foot is empty, and this appears to be the
case only for the vote section.
BTW, I'm not sure the <br /> is very usefull, elinks renders the page in
the same way without it, but that's my only webbrowser, so I haven't
really checked this.
please check the patch before using it
Regards
Nicolas Bertolissio
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.4
Locale: LANG=3Dfr_FR@euro, LC_CTYPE=3Dfr_FR@euro
--=20
--fUYQa+Pmc3FrFX/N
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="recent_list.wml.diff"
Content-Transfer-Encoding: quoted-printable
Index: recent_list.wml
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/webwml/webwml/english/template/debian/recent_list.wml,v
retrieving revision 1.119
diff -u -r1.119 recent_list.wml
--- recent_list.wml 30 Apr 2004 08:32:09 -0000 1.119
+++ recent_list.wml 19 May 2004 09:35:48 -0000
@@ -78,7 +78,7 @@
# 3) News/2002/index.wml
# get_recent_list ('.', '0', '$(ENGLISHDIR)/News/2002', '', '\d+\w*')
=20
-my ($listhead, $listfoot, $elemhead, $elemdate, $elemfoot, $elemrealfoot);
+my ($listhead, $listfoot, $elemhead, $elemdate, $elemfoot, $elememptyfoot,=
$elemrealfoot);
my $is_events =3D 0;
my $is_by_date =3D 0;
=20
@@ -123,12 +123,14 @@
$listfoot =3D '</ol>';
$elemhead =3D '<li>';
$elemfoot =3D '- ';
+ $elememptyfoot =3D '</li>';
$elemrealfoot =3D '</li>';
} elsif ($format =3D~ bullet) {
$listhead =3D '<ul>';
$listfoot =3D '</ul>';
$elemhead =3D '<li>';
$elemfoot =3D '- ';
+ $elememptyfoot =3D '</li>';
$elemrealfoot =3D '</li>';
} elsif ($format =3D~ list) {
$listhead =3D '<dl>';
@@ -136,6 +138,7 @@
$listfoot =3D '</dl>';
$elemhead =3D '<dt>';
$elemfoot =3D '</dt><dd>';
+ $elememptyfoot =3D '</dt>';
$elemrealfoot =3D '</dd>';
} elsif ($format =3D~ table) {
$listhead =3D '<table>';
@@ -143,12 +146,14 @@
$elemhead =3D '<tr><td>';
$elemdate =3D '</td><td>';
$elemfoot =3D '';
+ $elememptyfoot =3D ' </td></tr>';
$elemrealfoot =3D '</td></tr>';
} else {
$listhead =3D '';
$listfoot =3D '';
$elemhead =3D '';
$elemfoot =3D '- ';
+ $elememptyfoot =3D '';
$elemrealfoot =3D '';
}
</protect>
@@ -403,7 +408,7 @@
elsif ( $status eq "F" ) { $str1 .=3D "<finished/>"; }
elsif ( $status eq "W" ) { $str1 .=3D "<withdrawn/>"; }
else { $str1 .=3D "$status"; }
- $str1 .=3D "<br />$elemfoot$elemrealfoot\n";
+ $str1 .=3D "<br />$elememptyfoot\n";
}
=20
if (!$is_by_date || ($hdate eq "")) {
--fUYQa+Pmc3FrFX/N--
--V0207lvV8h4k8FAm
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFAqzSXPnQ0OX3ZAY0RAvaRAJ9sqZhOoJKK+dywQHwLqqnb+pRb2wCghTGY
Q51aomvPgFscO6YCdoYSGS8=
=AMYL
-----END PGP SIGNATURE-----
--V0207lvV8h4k8FAm--
---------------------------------------
Received: (at 249801-done) by bugs.debian.org; 20 May 2004 00:42:25 +0000
>From kraai@lafn.org Wed May 19 17:42:25 2004
Return-path: <kraai@lafn.org>
Received: from zoot.lafn.org [206.117.18.6]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1BQbdh-0006I4-00; Wed, 19 May 2004 17:42:25 -0700
Received: from localhost (host-66-81-31-64.rev.o1.com [66.81.31.64])
by zoot.lafn.org (8.12.3p3/8.12.3) with ESMTP id i4K0gHQj074934
(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO);
Wed, 19 May 2004 17:42:23 -0700 (PDT)
(envelope-from kraai@lafn.org)
Received: from kraai by localhost with local (Exim 4.32)
id 1BQbem-0000D7-LX; Wed, 19 May 2004 17:43:32 -0700
Date: Wed, 19 May 2004 17:43:32 -0700
From: Matt Kraai <kraai@ftbfs.org>
To: Nicolas Bertolissio <nico.bertol@free.fr>, 249801-done@bugs.debian.org
Subject: Re: Bug#249801: www.debian.org: tidy reports trimming empty <dd> for vote pages
Message-ID: <20040520004332.GB623@catalunya>
References: <[🔎] 20040519101903.GC2341@free.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[🔎] 20040519101903.GC2341@free.fr>
User-Agent: Mutt/1.5.6i
Sender: Matt Kraai <kraai@lafn.org>
X-Virus-Scanned: clamd / ClamAV version 0.70, clamav-milter version 0.70j
Delivered-To: 249801-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-4.5 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER,
HTML_MESSAGE autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
On Wed, May 19, 2004 at 12:19:03PM +0200, Nicolas Bertolissio wrote:
> looking at
> http://people.debian.org/~alfie/tidy/fr
> tidy reports some warning about empty <dd> tags, here is a patch that
> should solve this problem for vote pages, where in fact it is the only
> case where there is nothing between the two variable
> $elemfoot$elemrealfoot in the wml code, the new variable $elememptyfoot
> should be used each time the foot is empty, and this appears to be the
> case only for the vote section.
>
> BTW, I'm not sure the <br /> is very usefull, elinks renders the page in
> the same way without it, but that's my only webbrowser, so I haven't
> really checked this.
>
> please check the patch before using it
Thanks for the patch; I've applied it.
--
Matt Kraai kraai@ftbfs.org http://ftbfs.org/
Reply to: