Bug#181872: Patch
On Thu, Mar 13, 2003 at 03:42:54PM +0100, Frank Lichtenheld wrote:
> tags 181872 + patch
> thanks
>
> [Problem of '<URL: http://scummvm.sf.net/compatibility.php>'
> being converted to
> '<URL: <a href="http://scummvm.sf.net/compatibility.php>">http://scummvm.sf.net/compatibility.php></a>']
>
> The following patch should fix the problem. It allows whitespaces
> beetween "<URL:" and "http://". I've also added some more handling of
> html special chars.
>
> I can commit it myself. Just say if I should.
Actually you shouldn't be able to... but regardless.
> --- pages.pl 30 Jan 2003 14:43:59 -0000 1.9
> +++ pages.pl 13 Mar 2003 14:30:56 -0000
> - $long_desc =~ s,<((URL:)?http://[\S~-]+?/?)>,\<\;$1\>\;,go;
> + $long_desc =~ s,<((URL:)?\s*http://[\S~-]+?/?)>,\<\;$1\>\;,go;
> + $long_desc =~ s/</\<\;/go;
> + $long_desc =~ s/>/\>\;/go;
The right fix would be simply
$long_desc =~ s,<(?:URL:\s*)?(http://[^>]+)\s*>,\<\;$1\>\;,go;
Right?
Also,
> + $long_desc =~ s/\&/\&\;/go;
That sounds like a fix for another bug, and it doesn't look like it would
actually handle the read &s in descriptions...
--
2. That which causes joy or happiness.
Reply to: