[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] dsa.XX.rdf & dsa-long.XX.rdf



* Josip Rodin <joy@gkvk.hr> [2002-11-25 19:57]:
> On Mon, Nov 25, 2002 at 04:05:53PM +0100, Gerfried Fuchs wrote:
>>  Uhm, you are right, was just a leftover...  It was meant to be closed
>> there.  Changed that now.  Do I need to send another diff or can you
>> think around that little change? :)
> 
> Oh, the other stuff doesn't seem worthy of discussion. :) Presuming you
> verified it works correctly.

 There *is* part that I consider worthy a discussion:  The question
which of the following two I should commit:

 if ($content =~ /^<define-tag pagetitle>\s*(.*?)\s*<\/define-tag>$/ms) {
or
 if ($content =~ /^<define-tag pagetitle>\s*(.*?)\s*<\/define-tag>$/m) {

 Mention the absence of s in the second line.  Without the s we stay
with the current version.  If we add the s we would enable multiline
<define-tag>s for the things (some people wrap them and wonder why they
don't work).

 Furthermore I also would like to liften the dependency that the start
tag must be at the start of a line and the end tag at the end.  It might
be useful to allow whitspace at the start, e.g., for formating or such.

 And of course which of the following two I should take:

 if ($content =~ /^<define-tag moreinfo>(.*?)<\/define-tag>$/ms) {
or
 if ($content =~ /^<define-tag moreinfo>(.*?)<\/(?:p|define-tag)>$/ms) {

 The second would get just the first paragraph from the DSA which
results in having mostly just valueable information in the long format.
I prefer the second one...

 So long,
Alfie
-- 
>ich habe schon einige Firewalls ausprobiert (Zonealarm, Norton und Jana) aber
>die Tiny gefällt mir am besten.  Nun meine Frage: was ist TCP und UDP und ICMP?
Uebernimmt die Hausratversicherung Bissmarken in der Tastatur?
  -- de.comp.security.firewall, <slrna084jl.ob9.sjaenick@azathoth.jaenicke.org>

Attachment: pgpT_20DvXBcH.pgp
Description: PGP signature


Reply to: