Bug#1120852: ITP: chatterino-libcommuni -- libcommuni with Cmake
On Fri, 21 Nov 2025 17:44:37 +0100 Rasmus Karlsson
<rasmus.karlsson@pajlada.com> wrote:
> On Thu, 20 Nov 2025 20:27:56 +0100 Tobias Frost <tobi@debian.org>
wrote:
> > For the code change, I only see minimal changes [1], mostly code
> > removals (most noeworthy removing encoding/decoding functionality and
> > hardcoding UTF-8 handling instead.)
> > Can expand on *why* you
> > need the fork before we look at the available
> > options?
>
>
> Our fork of libcommuni wasn't meant to be distributed - we've made lazy
> decisions to make it work for us in particular.
(ACK, I had the feeling too that this shouldn't be packaged.)
> The worthwhile changes we've made are related to building on later
> versions of Qt6. Since Qt 6.4, QTextCodec is no longer a valid header so
> it fails to compile without adding the Qt 5 Core Compatability APIs [1]
> to the build settings. Since we don't use that API, we ripped that out
> instead. I believe this PR [2] contains the minimally required patch for
> us to be able to use the system version of libcommuni when building with
> Qt6.
I see, and thanks for the PR upstream.
(Even if upstream libcommuni looks quiet these days, I'd still suggest to
try upstreaming as much as possible - would be not the first upstream
suddently becoming active again, or some fork is emerging and becomes
active upstream...)
Qt6 compatiblity will at some point also be required for libcommuni in
Debian, so I defintly will consider to have your patch in Debian, so I'd
suggest to file bugs against src:libcommmuni for patches you need for
chatterino and I guess I'll be able to accommondate this (I just need to
make sure that other packages using libcommuni don't get broken, but
that's at the moment, IIRC, only swift-im (needed for spectrum2)
At the moment Qt5 is available in Debian, so if chatterino works with
Qt5, this could be an (interim) option.
I'm liking cmake a lot and having a cmake based build system might
be beneficial, especially if it comes with .cmake files to be consumed
by dependencies. (With my Debian maintainer hat on, however, this is
something I don't want to have that as a patch in the Debian package,
that sould come from "upstream".
>
> [1] https://doc.qt.io/qt-6/qtcore5-index.html
>
> [2] https://github.com/communi/libcommuni/pull/116/files
>
>
--
Cheers,
tobi
Reply to: